Patchwork powerpc: Use generic PHY driver for Marvell 88E1111 PHY on GE Fanuc SBC610

login
register
mail settings
Submitter Martyn Welch
Date Nov. 18, 2008, 10:55 a.m.
Message ID <20081118105451.7835.78476.stgit@ubuntu8041.localdomain>
Download mbox | patch
Permalink /patch/9404/
State Accepted
Delegated to: Kumar Gala
Headers show

Comments

Martyn Welch - Nov. 18, 2008, 10:55 a.m.
The Marvell PHY driver is currently being used for the 88E1111 on the
SBC610. This driver is causing the link to run in 10/Half mode, the generic
PHY driver is correctly configuring the PHY as 1000/Full.

Edit default config to use generic PHY driver.

Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
---

Agh! My mistake - forgot to add "Signed-off", sorry.

 arch/powerpc/configs/86xx/gef_sbc610_defconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Kumar Gala - Nov. 18, 2008, 1:39 p.m.
On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:

> The Marvell PHY driver is currently being used for the 88E1111 on the
> SBC610. This driver is causing the link to run in 10/Half mode, the  
> generic
> PHY driver is correctly configuring the PHY as 1000/Full.
>
> Edit default config to use generic PHY driver.
>
> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
> ---
>
> Agh! My mistake - forgot to add "Signed-off", sorry.
>
> arch/powerpc/configs/86xx/gef_sbc610_defconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

hmm.. why not fix the issue with the 88e1111 driver.

- k
Martyn Welch - Nov. 18, 2008, 1:53 p.m.
On Tue, 18 Nov 2008 07:39:21 -0600
Kumar Gala <galak@kernel.crashing.org> wrote:
> 
> On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:
> 
> > The Marvell PHY driver is currently being used for the 88E1111 on the
> > SBC610. This driver is causing the link to run in 10/Half mode, the  
> > generic
> > PHY driver is correctly configuring the PHY as 1000/Full.
> >
> > Edit default config to use generic PHY driver.
> >
> > Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
> > ---
> >
> > Agh! My mistake - forgot to add "Signed-off", sorry.
> >
> > arch/powerpc/configs/86xx/gef_sbc610_defconfig |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> hmm.. why not fix the issue with the 88e1111 driver.
> 

Two reasons really:

1) We don't use any of the non-generic features of the PHY.
2) Networking is really _not_ my forte.

As a result, it's not itching ;-)

Martyn
Kumar Gala - Nov. 19, 2008, 8:57 p.m.
On Nov 18, 2008, at 4:55 AM, Martyn Welch wrote:

> The Marvell PHY driver is currently being used for the 88E1111 on the
> SBC610. This driver is causing the link to run in 10/Half mode, the  
> generic
> PHY driver is correctly configuring the PHY as 1000/Full.
>
> Edit default config to use generic PHY driver.
>
> Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
> ---
>
> Agh! My mistake - forgot to add "Signed-off", sorry.
>
> arch/powerpc/configs/86xx/gef_sbc610_defconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

applied to merge.

(I still think you should fix it to work with the proper driver).

- k

Patch

diff --git a/arch/powerpc/configs/86xx/gef_sbc610_defconfig b/arch/powerpc/configs/86xx/gef_sbc610_defconfig
index 2da13e0..07ccaf8 100644
--- a/arch/powerpc/configs/86xx/gef_sbc610_defconfig
+++ b/arch/powerpc/configs/86xx/gef_sbc610_defconfig
@@ -838,7 +838,7 @@  CONFIG_PHYLIB=y
 #
 # MII PHY device drivers
 #
-CONFIG_MARVELL_PHY=y
+# CONFIG_MARVELL_PHY is not set
 # CONFIG_DAVICOM_PHY is not set
 # CONFIG_QSEMI_PHY is not set
 # CONFIG_LXT_PHY is not set