From patchwork Wed May 4 12:40:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 94035 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3692BB6F14 for ; Wed, 4 May 2011 22:42:51 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C00EB280D7; Wed, 4 May 2011 14:42:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8ovD+PETtnZR; Wed, 4 May 2011 14:42:16 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6198C280DF; Wed, 4 May 2011 14:41:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 959FC280A9 for ; Wed, 4 May 2011 14:41:35 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QaFlY+z6xPzj for ; Wed, 4 May 2011 14:41:35 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from adserver.comelit.it (mail.comelit.it [217.56.59.218]) by theia.denx.de (Postfix) with ESMTP id 04781280C6 for ; Wed, 4 May 2011 14:41:25 +0200 (CEST) Received: from com-exc-01.comelit.it ([172.24.0.31]) by adserver.comelit.it with Microsoft SMTPSVC(6.0.3790.1830); Wed, 4 May 2011 14:41:25 +0200 Received: from wallace.comelit.it ([172.20.0.35]) by com-exc-01.comelit.it with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 May 2011 14:41:24 +0200 From: Luca Ceresoli To: u-boot@lists.denx.de Date: Wed, 4 May 2011 14:40:47 +0200 Message-Id: <1304512847-7351-9-git-send-email-luca.ceresoli@comelit.it> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1304512847-7351-1-git-send-email-luca.ceresoli@comelit.it> References: <1304512847-7351-1-git-send-email-luca.ceresoli@comelit.it> X-OriginalArrivalTime: 04 May 2011 12:41:24.0240 (UTC) FILETIME=[93F1D100:01CC0A58] X-TM-AS-Product-Ver: SMEX-8.6.0.1168-6.500.1024-18114.004 X-TM-AS-Result: No--3.718300-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Cc: Ben Warren , Luca Ceresoli Subject: [U-Boot] [PATCH 8/8] net/net.c: cosmetic: do not use assignment in if condition X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This removes the following checkpatch issue: - ERROR: do not use assignment in if condition Signed-off-by: Luca Ceresoli Cc: Wolfgang Denk Cc: Ben Warren --- net/net.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/net.c b/net/net.c index 13efa67..c17d071 100644 --- a/net/net.c +++ b/net/net.c @@ -1616,7 +1616,8 @@ NetReceive(volatile uchar *inpkt, int len) * a fragment, and either the complete packet or NULL if * it is a fragment (if !CONFIG_IP_DEFRAG, it returns NULL) */ - if (!(ip = NetDefragment(ip, &len))) + ip = NetDefragment(ip, &len); + if (!ip) return; /* * watch for ICMP host redirects