From patchwork Wed May  4 11:26:48 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: add a check to prevent the incrementing of possible NULL value for
 "region" in onenand_base.c
Date: Wed, 04 May 2011 01:26:48 -0000
From: john.maxin@nokia.com
X-Patchwork-Id: 94001
Message-Id: <77DFD0EF40BC5042BB7221A1EFFF75709578@008-AM1MPN1-021.mgdnok.nokia.com>
To: <linux-mtd@lists.infradead.org>
Cc: kyungmin.park@samsung.com, dwmw2@infradead.org

Hi,

Coverity has reported that inside the function "onenand_block_by_block_erase()" in onenand_base.c, we should add checks to prevent the incrementing of possible NULL value for "region"
Thanks a lot to Adrian Hunter for suggesting a better solution.

Signed-off-by: Maxin B. John <john.maxin@nokia.com>

---


diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 56a8b20..fd659f8 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2424,7 +2424,7 @@ static int onenand_block_by_block_erase(struct mtd_info *mtd,
                len -= block_size;
                addr += block_size;

-               if (addr == region_end) {
+               if (region && addr == region_end) {
                        if (!len)
                                break;
                        region++;