Patchwork add a check to prevent the incrementing of possible NULL value for "region" in onenand_base.c

login
register
mail settings
Submitter john.maxin@nokia.com
Date May 4, 2011, 11:26 a.m.
Message ID <77DFD0EF40BC5042BB7221A1EFFF75709578@008-AM1MPN1-021.mgdnok.nokia.com>
Download mbox | patch
Permalink /patch/94001/
State New
Headers show

Comments

john.maxin@nokia.com - May 4, 2011, 11:26 a.m.
Hi,

Coverity has reported that inside the function "onenand_block_by_block_erase()" in onenand_base.c, we should add checks to prevent the incrementing of possible NULL value for "region"
Thanks a lot to Adrian Hunter for suggesting a better solution.

Signed-off-by: Maxin B. John <john.maxin@nokia.com>
---
Artem Bityutskiy - May 5, 2011, 6:51 p.m.
On Wed, 2011-05-04 at 11:26 +0000, john.maxin@nokia.com wrote:
> Hi,
> 
> Coverity has reported that inside the function "onenand_block_by_block_erase()" in onenand_base.c, we should add checks to prevent the incrementing of possible NULL value for "region"
> Thanks a lot to Adrian Hunter for suggesting a better solution.
> 
> Signed-off-by: Maxin B. John <john.maxin@nokia.com>

The commit message should not contain that long lines - use max 80
lines. The commit message should not start with "Hi". The subject should
be short and more high level - the details go to the commit message.
Could you please improve this and re-submit?

> ---
> diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
> index 56a8b20..fd659f8 100644
> --- a/drivers/mtd/onenand/onenand_base.c
> +++ b/drivers/mtd/onenand/onenand_base.c
> @@ -2424,7 +2424,7 @@ static int onenand_block_by_block_erase(struct mtd_info *mtd,
>                 len -= block_size;
>                 addr += block_size;
> 
> -               if (addr == region_end) {
> +               if (region && addr == region_end) {
>                         if (!len)
>                                 break;
>                         region++;
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
john.maxin@nokia.com - May 6, 2011, 8:33 a.m.
Hi Artem,

>The commit message should not contain that long lines - use max 80
>lines. The commit message should not start with "Hi". The subject should
>be short and more high level - the details go to the commit message.
>Could you please improve this and re-submit?

Oops.. I am sorry. Thanks a lot for pointing out my mistakes.
I will make the modifications as per your instruction and will resubmit the patch.  

Thanks and Regards,
Maxin

Patch

diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index 56a8b20..fd659f8 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2424,7 +2424,7 @@  static int onenand_block_by_block_erase(struct mtd_info *mtd,
                len -= block_size;
                addr += block_size;

-               if (addr == region_end) {
+               if (region && addr == region_end) {
                        if (!len)
                                break;
                        region++;