diff mbox series

[v2,4/7] tests/bios-tables-test: Remove an useless cast

Message ID 20180705155811.20366-5-f4bug@amsat.org
State New
Headers show
Series Coccinelle cleanups | expand

Commit Message

Philippe Mathieu-Daudé July 5, 2018, 3:58 p.m. UTC
Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/typecast.cocci \
            --macro-file scripts/cocci-macro-file.h \
            --dir . --in-place

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Blake July 5, 2018, 4:13 p.m. UTC | #1
On 07/05/2018 10:58 AM, Philippe Mathieu-Daudé wrote:
> Patch created mechanically by rerunning:

In the subject: s/an useless/a useless/

(English is weird; we use "a" when the 'u' is pronounced hard as in 
"unicorn", and "an" when the 'u' is soft as in "umbrella")

> 
>    $  spatch --sp-file scripts/coccinelle/typecast.cocci \
>              --macro-file scripts/cocci-macro-file.h \
>              --dir . --in-place
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
Philippe Mathieu-Daudé July 5, 2018, 4:17 p.m. UTC | #2
On 07/05/2018 01:13 PM, Eric Blake wrote:
> On 07/05/2018 10:58 AM, Philippe Mathieu-Daudé wrote:
>> Patch created mechanically by rerunning:
> 
> In the subject: s/an useless/a useless/
> 
> (English is weird; we use "a" when the 'u' is pronounced hard as in
> "unicorn", and "an" when the 'u' is soft as in "umbrella")

TIL, thanks for catching/correcting this Eric :)

>>
>>    $  spatch --sp-file scripts/coccinelle/typecast.cocci \
>>              --macro-file scripts/cocci-macro-file.h \
>>              --dir . --in-place
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
diff mbox series

Patch

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 4e24930c4b..c1ad1b3470 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -319,7 +319,7 @@  static bool load_asl(GArray *sdts, AcpiSdtTable *sdt)
     ret = g_spawn_command_line_sync(command_line->str, &out, &out_err, NULL, &error);
     g_assert_no_error(error);
     if (ret) {
-        ret = g_file_get_contents(sdt->asl_file, (gchar **)&sdt->asl,
+        ret = g_file_get_contents(sdt->asl_file, &sdt->asl,
                                   &sdt->asl_len, &error);
         g_assert(ret);
         g_assert_no_error(error);