diff mbox series

[21/27] bcma: Allow selection of this driver when COMPILE_TEST=y

Message ID 20180705094522.12138-22-boris.brezillon@bootlin.com
State Accepted
Delegated to: Miquel Raynal
Headers show
Series mtd: rawnand: Improve compile-test coverage | expand

Commit Message

Boris Brezillon July 5, 2018, 9:45 a.m. UTC
This allows us to increase compile-test coverage without having to build
a kernel for MIPS.  That's particularly interesting for subsystem
maintainers that want to test as many drivers as possible in a single
build.

We also add a dependency on HAS_IOMEM in BCMA_HOST_SOC to make sure the
driver is not selected when the arch does not implement IO accessors.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
 drivers/bcma/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo July 6, 2018, 2:32 p.m. UTC | #1
Boris Brezillon <boris.brezillon@bootlin.com> writes:

> This allows us to increase compile-test coverage without having to build
> a kernel for MIPS.  That's particularly interesting for subsystem
> maintainers that want to test as many drivers as possible in a single
> build.
>
> We also add a dependency on HAS_IOMEM in BCMA_HOST_SOC to make sure the
> driver is not selected when the arch does not implement IO accessors.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
>  drivers/bcma/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Kalle Valo <kvalo@codeaurora.org>

I assume this patch will go via some other tree and I can drop it.
Boris Brezillon July 6, 2018, 2:37 p.m. UTC | #2
On Fri, 06 Jul 2018 17:32:50 +0300
Kalle Valo <kvalo@codeaurora.org> wrote:

> Boris Brezillon <boris.brezillon@bootlin.com> writes:
> 
> > This allows us to increase compile-test coverage without having to build
> > a kernel for MIPS.  That's particularly interesting for subsystem
> > maintainers that want to test as many drivers as possible in a single
> > build.
> >
> > We also add a dependency on HAS_IOMEM in BCMA_HOST_SOC to make sure the
> > driver is not selected when the arch does not implement IO accessors.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> >  drivers/bcma/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)  
> 
> Acked-by: Kalle Valo <kvalo@codeaurora.org>
> 
> I assume this patch will go via some other tree and I can drop it.
> 

Yep. We can create an immutable tag if needed.
diff mbox series

Patch

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index cb0f1aad20b7..b9558ff20830 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -30,6 +30,7 @@  config BCMA_HOST_PCI
 
 config BCMA_HOST_SOC
 	bool "Support for BCMA in a SoC"
+	depends on HAS_IOMEM
 	help
 	  Host interface for a Broadcom AIX bus directly mapped into
 	  the memory. This only works with the Broadcom SoCs from the
@@ -61,7 +62,7 @@  config BCMA_DRIVER_PCI_HOSTMODE
 
 config BCMA_DRIVER_MIPS
 	bool "BCMA Broadcom MIPS core driver"
-	depends on MIPS
+	depends on MIPS || COMPILE_TEST
 	help
 	  Driver for the Broadcom MIPS core attached to Broadcom specific
 	  Advanced Microcontroller Bus.