| Message ID | 20180705094522.12138-18-boris.brezillon@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: Improve compile-test coverage | expand |
On Thu, 5 Jul 2018 11:45:12 +0200 Boris Brezillon <boris.brezillon@bootlin.com> wrote: > It just makes NAND maintainers' life easier by allowing them to > compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK, > ARCH_U8500 or MACH_U300 enabled. > > We also need to add a dependency on HAS_IOMEM to make sure the driver > compiles correctly. > > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> > --- > drivers/mtd/nand/raw/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index b89bd94a654c..245f1b56b94f 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -502,8 +502,9 @@ config MTD_NAND_JZ4780 > > config MTD_NAND_FSMC > tristate "Support for NAND on ST Micros FSMC" > - depends on OF > - depends on PLAT_SPEAR || ARCH_NOMADIK || ARCH_U8500 || MACH_U300 > + depends on OF && HAS_IOMEM > + depends on PLAT_SPEAR || ARCH_NOMADIK || ARCH_U8500 || MACH_U300 || \ > + COMPILE_TEST Looks like we have a conflict on the PC definition when compiling a MIPS kernel. I'll add a patch suffixing PC with FSMC_ to avoid that. Please don't apply this patch yet. > help > Enables support for NAND Flash chips on the ST Microelectronics > Flexible Static Memory Controller (FSMC)
diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig index b89bd94a654c..245f1b56b94f 100644 --- a/drivers/mtd/nand/raw/Kconfig +++ b/drivers/mtd/nand/raw/Kconfig @@ -502,8 +502,9 @@ config MTD_NAND_JZ4780 config MTD_NAND_FSMC tristate "Support for NAND on ST Micros FSMC" - depends on OF - depends on PLAT_SPEAR || ARCH_NOMADIK || ARCH_U8500 || MACH_U300 + depends on OF && HAS_IOMEM + depends on PLAT_SPEAR || ARCH_NOMADIK || ARCH_U8500 || MACH_U300 || \ + COMPILE_TEST help Enables support for NAND Flash chips on the ST Microelectronics Flexible Static Memory Controller (FSMC)
It just makes NAND maintainers' life easier by allowing them to compile-test this driver without having PLAT_SPEAR, ARCH_NOMADIK, ARCH_U8500 or MACH_U300 enabled. We also need to add a dependency on HAS_IOMEM to make sure the driver compiles correctly. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- drivers/mtd/nand/raw/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)