ARM: tegra: Fix Tegra30 Cardhu PCA954x reset
diff mbox series

Message ID 1530608387-9591-1-git-send-email-jonathanh@nvidia.com
State Accepted
Headers show
Series
  • ARM: tegra: Fix Tegra30 Cardhu PCA954x reset
Related show

Commit Message

Jon Hunter July 3, 2018, 8:59 a.m. UTC
On all versions of Tegra30 Cardhu, the reset signal to the NXP PCA9546
I2C mux is connected to the Tegra GPIO BB0. Currently, this pin on the
Tegra is not configured as a GPIO but as a special-function IO (SFIO)
that is multiplexing the pin to an I2S controller. On exiting system
suspend, I2C commands sent to the PCA9546 are failing because there is
no ACK. Although it is not possible to see exactly what is happening
to the reset during suspend, by ensuring it is configured as a GPIO
and driven high, to de-assert the reset, the failures are no longer
seen.

Please note that this GPIO is also used to drive the reset signal
going to the camera connector on the board. However, given that there
is no camera support currently for Cardhu, this should not have any
impact.

Fixes: 40431d16ff11 ("ARM: tegra: enable PCA9546 on Cardhu")

Cc: stable@vger.kernel.org

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Thierry Reding July 9, 2018, 2:01 p.m. UTC | #1
On Tue, Jul 03, 2018 at 09:59:47AM +0100, Jon Hunter wrote:
> On all versions of Tegra30 Cardhu, the reset signal to the NXP PCA9546
> I2C mux is connected to the Tegra GPIO BB0. Currently, this pin on the
> Tegra is not configured as a GPIO but as a special-function IO (SFIO)
> that is multiplexing the pin to an I2S controller. On exiting system
> suspend, I2C commands sent to the PCA9546 are failing because there is
> no ACK. Although it is not possible to see exactly what is happening
> to the reset during suspend, by ensuring it is configured as a GPIO
> and driven high, to de-assert the reset, the failures are no longer
> seen.
> 
> Please note that this GPIO is also used to drive the reset signal
> going to the camera connector on the board. However, given that there
> is no camera support currently for Cardhu, this should not have any
> impact.
> 
> Fixes: 40431d16ff11 ("ARM: tegra: enable PCA9546 on Cardhu")
> 
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  arch/arm/boot/dts/tegra30-cardhu.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Applied to for-4.19/arm/dt, thanks.

Thierry

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 92a9740c533f..3b1db7b9ec50 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -206,6 +206,7 @@ 
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <0x70>;
+			reset-gpio = <&gpio TEGRA_GPIO(BB, 0) GPIO_ACTIVE_LOW>;
 		};
 	};