| Message ID | 20180703011026.18650-1-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | pc: Fix typo on PC_COMPAT_2_12 | expand |
On Mon, 2 Jul 2018 22:10:26 -0300 Eduardo Habkost <ehabkost@redhat.com> wrote: > I forgot a hyphen when amending the compat code on commit > e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU"). > > Fixes: e00516475c270dcb6705753da96063f95699abf2 > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Bug detected by compat_checker: > https://github.com/ehabkost/gdb-qemu > --- > include/hw/i386/pc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 4d99d69681..654003f44c 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > .property = "xlevel",\ > .value = stringify(0x8000000a),\ > },{\ > - .driver = "EPYC-IBPB" TYPE_X86_CPU,\ > + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\ > .property = "xlevel",\ > .value = stringify(0x8000000a),\ > }, Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Looks good. thanks > -----Original Message----- > From: Eduardo Habkost [mailto:ehabkost@redhat.com] > Sent: Monday, July 2, 2018 8:10 PM > To: qemu-devel@nongnu.org > Cc: Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini > <pbonzini@redhat.com>; Moger, Babu <Babu.Moger@amd.com>; Michael > S. Tsirkin <mst@redhat.com>; Igor Mammedov <imammedo@redhat.com> > Subject: [PATCH] pc: Fix typo on PC_COMPAT_2_12 > > I forgot a hyphen when amending the compat code on commit > e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU"). > > Fixes: e00516475c270dcb6705753da96063f95699abf2 > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Babu Moger <babu.moger@amd.com> > --- > Bug detected by compat_checker: > https://github.com/ehabkost/gdb-qemu > --- > include/hw/i386/pc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index 4d99d69681..654003f44c 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, > uint64_t *); > .property = "xlevel",\ > .value = stringify(0x8000000a),\ > },{\ > - .driver = "EPYC-IBPB" TYPE_X86_CPU,\ > + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\ > .property = "xlevel",\ > .value = stringify(0x8000000a),\ > }, > -- > 2.18.0.rc1.1.g3f1ff2140
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 4d99d69681..654003f44c 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); .property = "xlevel",\ .value = stringify(0x8000000a),\ },{\ - .driver = "EPYC-IBPB" TYPE_X86_CPU,\ + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\ .property = "xlevel",\ .value = stringify(0x8000000a),\ },
I forgot a hyphen when amending the compat code on commit e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU"). Fixes: e00516475c270dcb6705753da96063f95699abf2 Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Bug detected by compat_checker: https://github.com/ehabkost/gdb-qemu --- include/hw/i386/pc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)