mmc: tegra: enable ddr_signaling for MMC_TIMING_MMC_DDR52

Message ID 20180702220920.7676-1-tszucs@protonmail.ch
State New
Headers show
Series
  • mmc: tegra: enable ddr_signaling for MMC_TIMING_MMC_DDR52
Related show

Commit Message

Tamás Szűcs July 2, 2018, 10:09 p.m.
This fixes sampling errors with eMMC modules using DDR52 when host capabilities
via setting NVQUIRK_ENABLE_DDR50 and NVQUIRK_ENABLE_SDHCI_SPEC_300 are enabled.

Signed-off-by: Tamás Szűcs <tszucs@protonmail.ch>
---
 drivers/mmc/host/sdhci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Agner July 12, 2018, 10:37 a.m. | #1
On 03.07.2018 00:09, Tamás Szűcs wrote:
> This fixes sampling errors with eMMC modules using DDR52 when host capabilities
> via setting NVQUIRK_ENABLE_DDR50 and NVQUIRK_ENABLE_SDHCI_SPEC_300 are enabled.

Sorry, just sent a patch which fixes the same:
https://patchwork.kernel.org/patch/10521145/

FWIW, this patch should go through the MMC subsystem. You should use
./scripts/get_maintainer.pl to send it to the maintainers and
appropriate mailing list (besides linux-tegra).

--
Stefan

> 
> Signed-off-by: Tamás Szűcs <tszucs@protonmail.ch>
> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..ae4ef27f1202 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -228,7 +228,7 @@ static void tegra_sdhci_set_uhs_signaling(struct
> sdhci_host *host,
>  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>  	struct sdhci_tegra *tegra_host = sdhci_pltfm_priv(pltfm_host);
>  
> -	if (timing == MMC_TIMING_UHS_DDR50)
> +	if (timing == MMC_TIMING_UHS_DDR50 || timing == MMC_TIMING_MMC_DDR52)
>  		tegra_host->ddr_signaling = true;
>  
>  	return sdhci_set_uhs_signaling(host, timing);
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index b877c13184c2..ae4ef27f1202 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -228,7 +228,7 @@  static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
 	struct sdhci_tegra *tegra_host = sdhci_pltfm_priv(pltfm_host);
 
-	if (timing == MMC_TIMING_UHS_DDR50)
+	if (timing == MMC_TIMING_UHS_DDR50 || timing == MMC_TIMING_MMC_DDR52)
 		tegra_host->ddr_signaling = true;
 
 	return sdhci_set_uhs_signaling(host, timing);