[U-Boot,v2,7/8] arm/km: change default settings for egiga on mgcoge3un

From: Holger Brunck <holger.brunck@keymile.com>

The reason we need this is that we have the gig port on mgcoge3un
connected using a back-to-back pair of PHYs. There are no magnetics and
because of that the port has to be run with a fixd configuration and
auto-negotiation must be disabled. In the default mode the egiga driver
uses autoneg to determine port speed - which defaults to 1G (we need
100M full duplex).

Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Acked-by: Heiko Schocher <hs@denx.de>
Acked-by: Prafulla Wadaskar <Prafulla@marvell.com>
cc: Wolfgang Denk <wd@denx.de>
cc: Detlev Zundel <dzu@denx.de>
---
Changes for v2:
   - split up first large patch series to three independent smaller
     patch series

 drivers/net/mvgbe.h         |    2 ++
 include/configs/mgcoge3un.h |   25 +++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 0 deletions(-)

> -----Original Message-----
> From: Valentin Longchamp [mailto:valentin.longchamp@keymile.com]
> Sent: Tuesday, May 03, 2011 7:43 PM
> To: u-boot@lists.denx.de
> Cc: Prafulla Wadaskar; holger.brunck@keymile.com; Valentin Longchamp;
> Wolfgang Denk; Detlev Zundel
> Subject: [PATCH v2 7/8] arm/km: change default settings for egiga on
> mgcoge3un
> 
> From: Holger Brunck <holger.brunck@keymile.com>
> 
> The reason we need this is that we have the gig port on mgcoge3un
> connected using a back-to-back pair of PHYs. There are no magnetics and
> because of that the port has to be run with a fixd configuration and
> auto-negotiation must be disabled. In the default mode the egiga driver
> uses autoneg to determine port speed - which defaults to 1G (we need
> 100M full duplex).
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> Acked-by: Prafulla Wadaskar <Prafulla@marvell.com>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Detlev Zundel <dzu@denx.de>
> ---
> Changes for v2:
>    - split up first large patch series to three independent smaller
>      patch series
> 
>  drivers/net/mvgbe.h         |    2 ++
>  include/configs/mgcoge3un.h |   25 +++++++++++++++++++++++++

It will be good if you split this patch, the mvgbe.h change would be generic, independent and can be merged faster.

mgcoge3un.h changes would be part of your new board config.

Regards..
Prafulla ..

Prafulla Wadaskar wrote:
> 
>> -----Original Message-----
>> From: Valentin Longchamp [mailto:valentin.longchamp@keymile.com]
>> Sent: Tuesday, May 03, 2011 7:43 PM
>> To: u-boot@lists.denx.de
>> Cc: Prafulla Wadaskar; holger.brunck@keymile.com; Valentin Longchamp;
>> Wolfgang Denk; Detlev Zundel
>> Subject: [PATCH v2 7/8] arm/km: change default settings for egiga on
>> mgcoge3un
>>
>> From: Holger Brunck <holger.brunck@keymile.com>
>>
>> The reason we need this is that we have the gig port on mgcoge3un
>> connected using a back-to-back pair of PHYs. There are no magnetics and
>> because of that the port has to be run with a fixd configuration and
>> auto-negotiation must be disabled. In the default mode the egiga driver
>> uses autoneg to determine port speed - which defaults to 1G (we need
>> 100M full duplex).
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> Acked-by: Heiko Schocher <hs@denx.de>
>> Acked-by: Prafulla Wadaskar <Prafulla@marvell.com>
>> cc: Wolfgang Denk <wd@denx.de>
>> cc: Detlev Zundel <dzu@denx.de>
>> ---
>> Changes for v2:
>>    - split up first large patch series to three independent smaller
>>      patch series
>>
>>  drivers/net/mvgbe.h         |    2 ++
>>  include/configs/mgcoge3un.h |   25 +++++++++++++++++++++++++
> 
> It will be good if you split this patch, the mvgbe.h change would be generic, independent and can be merged faster.
> 
> mgcoge3un.h changes would be part of your new board config.
> 

Ok, I agree, I will split them.

Regards

Dear Prafulla Wadaskar,

In message <F766E4F80769BD478052FB6533FA745D19FAC25C77@SC-VEXCH4.marvell.com> you wrote:
> 
> It will be good if you split this patch, the mvgbe.h change would be generi=
> c, independent and can be merged faster.
> 
> mgcoge3un.h changes would be part of your new board config.

When requesting changes like here, could you (and all other
custodians!) please update the patch state (to "Changes Requested") in
PatchWork?

Thanks!

Best regards,

Wolfgang Denk