Patchwork [U-Boot,v2,1/2] cramfs: fix bug in using CONFIG_CRAMFS_CMDLINE

login
register
mail settings
Submitter Heiko Schocher
Date May 3, 2011, 12:15 p.m.
Message ID <1304424901-17089-1-git-send-email-hs@denx.de>
Download mbox | patch
Permalink /patch/93779/
State Accepted
Commit ee8bc961a47563b0e6f92f3843959304a19412dc
Headers show

Comments

Heiko Schocher - May 3, 2011, 12:15 p.m.
do not define own flash_info variable, instead use
the flash_info variable defined in your flash driver.

Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Wolfgang Denk <wd@denx.de>
cc: Detlev Zundel <dzu@denx.de>
cc: Valentin Longchamp <valentin.longchamp@keymile.com>
cc: Holger Brunck <holger.brunck@keymile.com>
Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
---
changes for v2:
- added comments from Wolfgang Denk:
  - new patch in this version
  - no ifndef around include <flash.h> needed

 common/cmd_cramfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfgang Denk - May 10, 2011, 8:47 p.m.
Dear Heiko Schocher,

In message <1304424901-17089-1-git-send-email-hs@denx.de> you wrote:
> do not define own flash_info variable, instead use
> the flash_info variable defined in your flash driver.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> cc: Wolfgang Denk <wd@denx.de>
> cc: Detlev Zundel <dzu@denx.de>
> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Holger Brunck <holger.brunck@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
> changes for v2:
> - added comments from Wolfgang Denk:
>   - new patch in this version
>   - no ifndef around include <flash.h> needed
> 
>  common/cmd_cramfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_cramfs.c b/common/cmd_cramfs.c
index 8c86dc5..9060ecc 100644
--- a/common/cmd_cramfs.c
+++ b/common/cmd_cramfs.c
@@ -43,7 +43,7 @@ 
 #endif
 
 #ifdef CONFIG_CRAMFS_CMDLINE
-flash_info_t flash_info[1];
+#include <flash.h>
 
 #ifndef CONFIG_CMD_JFFS2
 #include <linux/stat.h>