[v3,3/9] PCI: keystone: Drop unnecessary root_bus_nr setting

Message ID 1530417291-30495-4-git-send-email-shawn.guo@linaro.org
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series
  • PCI: dwc: Drop unnecessary root_bus_nr setting
Related show

Commit Message

Shawn Guo July 1, 2018, 3:54 a.m.
Function dw_pcie_host_init() already initializes the root_bus_nr field
of 'struct pcie_port', so the -1 assignment prior to calling
dw_pcie_host_init() in platform specific driver is not really needed.
Drop it.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/pci/controller/dwc/pci-keystone.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Lorenzo Pieralisi July 4, 2018, 4:23 p.m. | #1
On Sun, Jul 01, 2018 at 11:54:45AM +0800, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Murali Karicheri <m-karicheri2@ti.com>
> ---
>  drivers/pci/controller/dwc/pci-keystone.c | 1 -
>  1 file changed, 1 deletion(-)

Hi Murali,

we would need your ACK to send this series upstream, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
> index 3722a5f31e5e..e88bd221fffe 100644
> --- a/drivers/pci/controller/dwc/pci-keystone.c
> +++ b/drivers/pci/controller/dwc/pci-keystone.c
> @@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
>  		}
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &keystone_pcie_host_ops;
>  	ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
>  	if (ret) {
> -- 
> 1.9.1
>

Patch

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 3722a5f31e5e..e88bd221fffe 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -347,7 +347,6 @@  static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
 		}
 	}
 
-	pp->root_bus_nr = -1;
 	pp->ops = &keystone_pcie_host_ops;
 	ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
 	if (ret) {