| Message ID | 20180629035106.27181-4-benh@kernel.crashing.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | arm: Aspeed DT & config updates for USB | expand |
On Fri, 29 Jun 2018, at 13:21, Benjamin Herrenschmidt wrote: > This adds the (disabled by default) device node for the > Aspeed virtual hub,a long with clocks and pinmux. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > arch/arm/boot/dts/aspeed-g4.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi > index 1d7ffa9fdb11..54524564037c 100644 > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > @@ -131,6 +131,16 @@ > */ > }; > > + vhub: usb-vhub@1e6a0000 { > + compatible = "aspeed,ast2400-usb-vhub"; > + reg = <0x1e6a0000 0x300>; > + interrupts = <5>; > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2d_default>; > + status = "disabled"; > + }; > + These are all generic properties, so it's pretty clear what's going on, but it seems there's no bindings document capturing the compatible string? Not wanting to be a pain, but shouldn't we have documented it? > apb { > compatible = "simple-bus"; > #address-cells = <1>; > -- > 2.17.1 >
On Mon, 2018-07-16 at 15:04 +0930, Andrew Jeffery wrote: > On Fri, 29 Jun 2018, at 13:21, Benjamin Herrenschmidt wrote: > > This adds the (disabled by default) device node for the > > Aspeed virtual hub,a long with clocks and pinmux. > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > --- > > arch/arm/boot/dts/aspeed-g4.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi > > index 1d7ffa9fdb11..54524564037c 100644 > > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > > @@ -131,6 +131,16 @@ > > */ > > }; > > > > + vhub: usb-vhub@1e6a0000 { > > + compatible = "aspeed,ast2400-usb-vhub"; > > + reg = <0x1e6a0000 0x300>; > > + interrupts = <5>; > > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usb2d_default>; > > + status = "disabled"; > > + }; > > + > > These are all generic properties, so it's pretty clear what's going > on, but it seems there's no bindings document capturing the > compatible string? Not wanting to be a pain, but shouldn't we have > documented it? The driver went in at a time when I hadn't realized we documented bindings for devices using only standard properties these days. We can send a binding to Rob later. Cheers, Ben. > > > apb { > > compatible = "simple-bus"; > > #address-cells = <1>; > > -- > > 2.17.1 > >
On Mon, 16 Jul 2018, at 16:10, Benjamin Herrenschmidt wrote: > On Mon, 2018-07-16 at 15:04 +0930, Andrew Jeffery wrote: > > On Fri, 29 Jun 2018, at 13:21, Benjamin Herrenschmidt wrote: > > > This adds the (disabled by default) device node for the > > > Aspeed virtual hub,a long with clocks and pinmux. > > > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > > --- > > > arch/arm/boot/dts/aspeed-g4.dtsi | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi > > > index 1d7ffa9fdb11..54524564037c 100644 > > > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > > > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > > > @@ -131,6 +131,16 @@ > > > */ > > > }; > > > > > > + vhub: usb-vhub@1e6a0000 { > > > + compatible = "aspeed,ast2400-usb-vhub"; > > > + reg = <0x1e6a0000 0x300>; > > > + interrupts = <5>; > > > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usb2d_default>; > > > + status = "disabled"; > > > + }; > > > + > > > > These are all generic properties, so it's pretty clear what's going > > on, but it seems there's no bindings document capturing the > > compatible string? Not wanting to be a pain, but shouldn't we have > > documented it? > > The driver went in at a time when I hadn't realized we documented > bindings for devices using only standard properties these days. We can > send a binding to Rob later. Yep, I can't see it being controversial. Acked-by: Andrew Jeffery <andrew@aj.id.au> > > Cheers, > Ben. > > > > > > apb { > > > compatible = "simple-bus"; > > > #address-cells = <1>; > > > -- > > > 2.17.1 > > >
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi index 1d7ffa9fdb11..54524564037c 100644 --- a/arch/arm/boot/dts/aspeed-g4.dtsi +++ b/arch/arm/boot/dts/aspeed-g4.dtsi @@ -131,6 +131,16 @@ */ }; + vhub: usb-vhub@1e6a0000 { + compatible = "aspeed,ast2400-usb-vhub"; + reg = <0x1e6a0000 0x300>; + interrupts = <5>; + clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb2d_default>; + status = "disabled"; + }; + apb { compatible = "simple-bus"; #address-cells = <1>;
This adds the (disabled by default) device node for the Aspeed virtual hub,a long with clocks and pinmux. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- arch/arm/boot/dts/aspeed-g4.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)