Patchwork [U-Boot,v3,2/3] ftsmc020: un-nest the register structure in header

login
register
mail settings
Submitter Macpaul Lin
Date May 2, 2011, 8:17 a.m.
Message ID <1304324251-15293-2-git-send-email-macpaul@andestech.com>
Download mbox | patch
Permalink /patch/93607/
State Accepted
Commit 56cd247232b455d80eb1b9a7009e8c043682b379
Headers show

Comments

Macpaul Lin - May 2, 2011, 8:17 a.m.
Un-nestted the register structure in ftsmc020.h

Signed-off-by: Macpaul Lin <macpaul@andestech.com>
---
Changes for v2:
  - Remove assembly register offsets for support lowlevel_init.S.
  - The nested structure of register offsets has been rewrote.
  - Fix relocation related declaration.
Changes for v3:
  - Split this patch into 3 different patches according to Wolfgang's suggestion
   - Fix gloable declarations to avoid problem in relocation.
   - Un-nested the register structure.
   - Add missing definitions in header according to datasheet.

 include/faraday/ftsmc020.h |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)
Wolfgang Denk - May 12, 2011, 9:43 p.m.
Dear Macpaul Lin,

In message <1304324251-15293-2-git-send-email-macpaul@andestech.com> you wrote:
> Un-nestted the register structure in ftsmc020.h
> 
> Signed-off-by: Macpaul Lin <macpaul@andestech.com>
> ---
> Changes for v2:
>   - Remove assembly register offsets for support lowlevel_init.S.
>   - The nested structure of register offsets has been rewrote.
>   - Fix relocation related declaration.
> Changes for v3:
>   - Split this patch into 3 different patches according to Wolfgang's suggestion
>    - Fix gloable declarations to avoid problem in relocation.
>    - Un-nested the register structure.
>    - Add missing definitions in header according to datasheet.
> 
>  include/faraday/ftsmc020.h |   14 ++++++++------
>  1 files changed, 8 insertions(+), 6 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/faraday/ftsmc020.h b/include/faraday/ftsmc020.h
index a0c8689..0a3d5a2 100644
--- a/include/faraday/ftsmc020.h
+++ b/include/faraday/ftsmc020.h
@@ -25,13 +25,15 @@ 
 
 #ifndef __ASSEMBLY__
 
+struct ftsmc020_bank {
+	unsigned int    cr;
+	unsigned int    tpr;
+};
+
 struct ftsmc020 {
-	struct {
-		unsigned int	cr;	/* 0x00, 0x08, 0x10, 0x18 */
-		unsigned int	tpr;	/* 0x04, 0x0c, 0x14, 0x1c */
-	} bank[4];
-	unsigned int	pad[8];	/* 0x20 - 0x3c */
-	unsigned int	ssr;	/* 0x40 */
+	struct ftsmc020_bank bank[4];	/* 0x00 - 0x1c */
+	unsigned int	pad[8];		/* 0x20 - 0x3c */
+	unsigned int	ssr;		/* 0x40 */
 };
 
 void ftsmc020_init(void);