diff mbox series

audio/hda: adjust larger gaps faster

Message ID 20180627111925.30292-1-kraxel@redhat.com
State New
Headers show
Series audio/hda: adjust larger gaps faster | expand

Commit Message

Gerd Hoffmann June 27, 2018, 11:19 a.m. UTC 
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/audio/hda-codec.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

no-reply@patchew.org July 2, 2018, 2:29 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180627111925.30292-1-kraxel@redhat.com
Subject: [Qemu-devel] [PATCH] audio/hda: adjust larger gaps faster

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d7dfd2f5e0 audio/hda: adjust larger gaps faster

=== OUTPUT BEGIN ===
Checking PATCH 1/1: audio/hda: adjust larger gaps faster...
ERROR: spaces required around that '*' (ctx:VxV)
#17: FILE: hw/audio/hda-codec.c:207:
+    if (target_pos < -(2*limit)) {
                         ^

ERROR: spaces required around that '*' (ctx:VxV)
#18: FILE: hw/audio/hda-codec.c:208:
+        corr = -(4*HDA_TIMER_TICKS);
                   ^

total: 2 errors, 0 warnings, 9 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
diff mbox series

Patch

diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index fc4945086b..8a8214de74 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -204,6 +204,9 @@  static inline void hda_timer_sync_adjust(HDAAudioStream *st, int64_t target_pos)
     if (target_pos < -limit) {
         corr = -HDA_TIMER_TICKS;
     }
+    if (target_pos < -(2*limit)) {
+        corr = -(4*HDA_TIMER_TICKS);
+    }
     if (corr == 0) {
         return;
     }