[U-Boot] imx: imx7d-sdb: Add DM QSPI support
diff mbox series

Message ID 1530082140-37962-1-git-send-email-ye.li@nxp.com
State Changes Requested
Delegated to: Stefano Babic
Headers show
Series
  • [U-Boot] imx: imx7d-sdb: Add DM QSPI support
Related show

Commit Message

Ye Li June 27, 2018, 6:49 a.m. UTC
On iMX7D SabreSD board, the QSPI has pins conflict with EPDC (default).
To use QSPI, users have to rework the board (de-populate R388-R391, R396-R399
populate R392-R395, R299, R300). So we add new DTS file and new defconfig
dedicated for QSPI.

Other changes to support the DM QSPI:
 - Add QSPI node and alias spi0.
 - Modify spi4 (spi-gpio) node and add alias spi5 for it to avoid req
   conflict
 - Add EPDC node in imx7d.dtsi and disable it in imx7d-sdb-qspi.dts,
   to present the conflict.
 - Remove iomux settings of qspi in board codes which is not needed
   for DM driver.

Signed-off-by: Ye Li <ye.li@nxp.com>
---
 arch/arm/dts/Makefile                     |  3 +-
 arch/arm/dts/imx7d-sdb-qspi.dts           | 44 ++++++++++++++++
 arch/arm/dts/imx7d-sdb.dts                |  6 ++-
 arch/arm/dts/imx7d.dtsi                   | 12 +++++
 arch/arm/dts/imx7s.dtsi                   | 22 ++++++--
 board/freescale/mx7dsabresd/mx7dsabresd.c | 16 ------
 configs/mx7dsabresd_qspi_defconfig        | 83 +++++++++++++++++++++++++++++++
 include/configs/mx7dsabresd.h             |  4 +-
 8 files changed, 165 insertions(+), 25 deletions(-)
 create mode 100644 arch/arm/dts/imx7d-sdb-qspi.dts
 create mode 100644 configs/mx7dsabresd_qspi_defconfig

Comments

Jagan Teki June 27, 2018, 10:33 a.m. UTC | #1
On Wed, Jun 27, 2018 at 12:19 PM, Ye Li <ye.li@nxp.com> wrote:
> On iMX7D SabreSD board, the QSPI has pins conflict with EPDC (default).
> To use QSPI, users have to rework the board (de-populate R388-R391, R396-R399
> populate R392-R395, R299, R300). So we add new DTS file and new defconfig
> dedicated for QSPI.
>
> Other changes to support the DM QSPI:
>  - Add QSPI node and alias spi0.
>  - Modify spi4 (spi-gpio) node and add alias spi5 for it to avoid req
>    conflict
>  - Add EPDC node in imx7d.dtsi and disable it in imx7d-sdb-qspi.dts,
>    to present the conflict.
>  - Remove iomux settings of qspi in board codes which is not needed
>    for DM driver.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
>  arch/arm/dts/Makefile                     |  3 +-
>  arch/arm/dts/imx7d-sdb-qspi.dts           | 44 ++++++++++++++++
>  arch/arm/dts/imx7d-sdb.dts                |  6 ++-
>  arch/arm/dts/imx7d.dtsi                   | 12 +++++
>  arch/arm/dts/imx7s.dtsi                   | 22 ++++++--

[snip]

> +CONFIG_CMD_DFU=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_SF=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_BMP=y
> +CONFIG_CMD_CACHE=y
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_EXT4_WRITE=y
> +CONFIG_CMD_FAT=y
> +CONFIG_OF_CONTROL=y
> +CONFIG_DFU_MMC=y
> +CONFIG_DFU_RAM=y
> +CONFIG_DM_GPIO=y
> +CONFIG_DM_74X164=y
> +CONFIG_DM_I2C=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_IO_VOLTAGE=y
> +CONFIG_MMC_UHS_SUPPORT=y
> +CONFIG_MMC_HS200_SUPPORT=y
> +CONFIG_FSL_ESDHC=y

fyi, this will soon remove if no further update on dm- conversion [1]

> +CONFIG_FSL_QSPI=y

Better to do full dm conversion before using, otherwise we have
migration expire rule [2]

[1] https://patchwork.ozlabs.org/patch/911785/
[2] doc/driver-model/MIGRATION.txt
Ye Li June 27, 2018, 1:23 p.m. UTC | #2
On 6/27/2018 6:33 PM, Jagan Teki wrote:
> On Wed, Jun 27, 2018 at 12:19 PM, Ye Li <ye.li@nxp.com> wrote:
>> On iMX7D SabreSD board, the QSPI has pins conflict with EPDC (default).
>> To use QSPI, users have to rework the board (de-populate R388-R391, R396-R399
>> populate R392-R395, R299, R300). So we add new DTS file and new defconfig
>> dedicated for QSPI.
>>
>> Other changes to support the DM QSPI:
>>  - Add QSPI node and alias spi0.
>>  - Modify spi4 (spi-gpio) node and add alias spi5 for it to avoid req
>>    conflict
>>  - Add EPDC node in imx7d.dtsi and disable it in imx7d-sdb-qspi.dts,
>>    to present the conflict.
>>  - Remove iomux settings of qspi in board codes which is not needed
>>    for DM driver.
>>
>> Signed-off-by: Ye Li <ye.li@nxp.com>
>> ---
>>  arch/arm/dts/Makefile                     |  3 +-
>>  arch/arm/dts/imx7d-sdb-qspi.dts           | 44 ++++++++++++++++
>>  arch/arm/dts/imx7d-sdb.dts                |  6 ++-
>>  arch/arm/dts/imx7d.dtsi                   | 12 +++++
>>  arch/arm/dts/imx7s.dtsi                   | 22 ++++++--
> 
> [snip]
> 
>> +CONFIG_CMD_DFU=y
>> +CONFIG_CMD_GPIO=y
>> +CONFIG_CMD_I2C=y
>> +CONFIG_CMD_MMC=y
>> +CONFIG_CMD_SF=y
>> +CONFIG_CMD_USB=y
>> +CONFIG_CMD_USB_MASS_STORAGE=y
>> +CONFIG_CMD_DHCP=y
>> +CONFIG_CMD_MII=y
>> +CONFIG_CMD_PING=y
>> +CONFIG_CMD_BMP=y
>> +CONFIG_CMD_CACHE=y
>> +CONFIG_CMD_PMIC=y
>> +CONFIG_CMD_REGULATOR=y
>> +CONFIG_CMD_EXT2=y
>> +CONFIG_CMD_EXT4=y
>> +CONFIG_CMD_EXT4_WRITE=y
>> +CONFIG_CMD_FAT=y
>> +CONFIG_OF_CONTROL=y
>> +CONFIG_DFU_MMC=y
>> +CONFIG_DFU_RAM=y
>> +CONFIG_DM_GPIO=y
>> +CONFIG_DM_74X164=y
>> +CONFIG_DM_I2C=y
>> +CONFIG_DM_MMC=y
>> +CONFIG_MMC_IO_VOLTAGE=y
>> +CONFIG_MMC_UHS_SUPPORT=y
>> +CONFIG_MMC_HS200_SUPPORT=y
>> +CONFIG_FSL_ESDHC=y
> 
> fyi, this will soon remove if no further update on dm- conversion [1]

It is CONFIG_FSL_ESPI in [1] not the CONFIG_FSL_ESDHC used here. Will the CONFIG_FSL_ESDHC be removed as well?

> 
>> +CONFIG_FSL_QSPI=y
> 
> Better to do full dm conversion before using, otherwise we have
> migration expire rule [2]

Ashish will do the full dm conversion for FSL_QSPI driver. Before that, we need to migrate all boards codes to use DM SPI driver to avoid break build.

Best regards,
Ye Li
> 
> [1] https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F911785%2F&data=02%7C01%7Cye.li%40nxp.com%7C6ccd2b315cfc47a1308108d5dc195de0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636656923865087981&sdata=8PyH66o2XHpa2vJ04FTv9keoT55uBM%2Bn2YUQwCmvBJ8%3D&reserved=0
> [2] doc/driver-model/MIGRATION.txt
>
Jagan Teki June 27, 2018, 3:45 p.m. UTC | #3
On Wed, Jun 27, 2018 at 6:53 PM, Ye Li <ye.li@nxp.com> wrote:
> On 6/27/2018 6:33 PM, Jagan Teki wrote:
>> On Wed, Jun 27, 2018 at 12:19 PM, Ye Li <ye.li@nxp.com> wrote:
>>> On iMX7D SabreSD board, the QSPI has pins conflict with EPDC (default).
>>> To use QSPI, users have to rework the board (de-populate R388-R391, R396-R399
>>> populate R392-R395, R299, R300). So we add new DTS file and new defconfig
>>> dedicated for QSPI.
>>>
>>> Other changes to support the DM QSPI:
>>>  - Add QSPI node and alias spi0.
>>>  - Modify spi4 (spi-gpio) node and add alias spi5 for it to avoid req
>>>    conflict
>>>  - Add EPDC node in imx7d.dtsi and disable it in imx7d-sdb-qspi.dts,
>>>    to present the conflict.
>>>  - Remove iomux settings of qspi in board codes which is not needed
>>>    for DM driver.
>>>
>>> Signed-off-by: Ye Li <ye.li@nxp.com>
>>> ---
>>>  arch/arm/dts/Makefile                     |  3 +-
>>>  arch/arm/dts/imx7d-sdb-qspi.dts           | 44 ++++++++++++++++
>>>  arch/arm/dts/imx7d-sdb.dts                |  6 ++-
>>>  arch/arm/dts/imx7d.dtsi                   | 12 +++++
>>>  arch/arm/dts/imx7s.dtsi                   | 22 ++++++--
>>
>> [snip]
>>
>>> +CONFIG_CMD_DFU=y
>>> +CONFIG_CMD_GPIO=y
>>> +CONFIG_CMD_I2C=y
>>> +CONFIG_CMD_MMC=y
>>> +CONFIG_CMD_SF=y
>>> +CONFIG_CMD_USB=y
>>> +CONFIG_CMD_USB_MASS_STORAGE=y
>>> +CONFIG_CMD_DHCP=y
>>> +CONFIG_CMD_MII=y
>>> +CONFIG_CMD_PING=y
>>> +CONFIG_CMD_BMP=y
>>> +CONFIG_CMD_CACHE=y
>>> +CONFIG_CMD_PMIC=y
>>> +CONFIG_CMD_REGULATOR=y
>>> +CONFIG_CMD_EXT2=y
>>> +CONFIG_CMD_EXT4=y
>>> +CONFIG_CMD_EXT4_WRITE=y
>>> +CONFIG_CMD_FAT=y
>>> +CONFIG_OF_CONTROL=y
>>> +CONFIG_DFU_MMC=y
>>> +CONFIG_DFU_RAM=y
>>> +CONFIG_DM_GPIO=y
>>> +CONFIG_DM_74X164=y
>>> +CONFIG_DM_I2C=y
>>> +CONFIG_DM_MMC=y
>>> +CONFIG_MMC_IO_VOLTAGE=y
>>> +CONFIG_MMC_UHS_SUPPORT=y
>>> +CONFIG_MMC_HS200_SUPPORT=y
>>> +CONFIG_FSL_ESDHC=y
>>
>> fyi, this will soon remove if no further update on dm- conversion [1]
>
> It is CONFIG_FSL_ESPI in [1] not the CONFIG_FSL_ESDHC used here. Will the CONFIG_FSL_ESDHC be removed as well?

OK, yes if not converted before v2018.09

>
>>
>>> +CONFIG_FSL_QSPI=y
>>
>> Better to do full dm conversion before using, otherwise we have
>> migration expire rule [2]
>
> Ashish will do the full dm conversion for FSL_QSPI driver. Before that, we need to migrate all boards codes to use DM SPI driver to avoid break build.

Nice.

Patch
diff mbox series

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 493652e..dfabec0 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -433,7 +433,8 @@  dtb-$(CONFIG_MX6UL) += \
 dtb-$(CONFIG_MX6ULL) += imx6ull-14x14-evk.dtb
 
 dtb-$(CONFIG_MX7) += imx7-colibri.dtb \
-	imx7d-sdb.dtb
+	imx7d-sdb.dtb \
+	imx7d-sdb-qspi.dtb
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
diff --git a/arch/arm/dts/imx7d-sdb-qspi.dts b/arch/arm/dts/imx7d-sdb-qspi.dts
new file mode 100644
index 0000000..38d69ec
--- /dev/null
+++ b/arch/arm/dts/imx7d-sdb-qspi.dts
@@ -0,0 +1,44 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
+ */
+
+#include "imx7d-sdb.dts"
+
+/* disable epdc, conflict with qspi */
+&epdc {
+        status = "disabled";
+};
+
+&iomuxc {
+	qspi1 {
+		pinctrl_qspi1_1: qspi1grp_1 {
+			fsl,pins = <
+				MX7D_PAD_EPDC_DATA00__QSPI_A_DATA0 0x51
+				MX7D_PAD_EPDC_DATA01__QSPI_A_DATA1 0x51
+				MX7D_PAD_EPDC_DATA02__QSPI_A_DATA2 0x51
+				MX7D_PAD_EPDC_DATA03__QSPI_A_DATA3 0x51
+				MX7D_PAD_EPDC_DATA05__QSPI_A_SCLK 0x51
+				MX7D_PAD_EPDC_DATA06__QSPI_A_SS0_B 0x51
+			>;
+		};
+	};
+};
+
+&qspi1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_qspi1_1>;
+	status = "okay";
+	ddrsmp=<0>;
+
+	flash0: mx25l51245g@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "spi-flash";
+		spi-max-frequency = <29000000>;
+		/* take off one dummy cycle */
+		spi-nor,ddr-quad-read-dummy = <5>;
+		reg = <0>;
+	};
+};
diff --git a/arch/arm/dts/imx7d-sdb.dts b/arch/arm/dts/imx7d-sdb.dts
index bafcc79..76aa69a 100644
--- a/arch/arm/dts/imx7d-sdb.dts
+++ b/arch/arm/dts/imx7d-sdb.dts
@@ -11,11 +11,15 @@ 
 	model = "Freescale i.MX7 SabreSD Board";
 	compatible = "fsl,imx7d-sdb", "fsl,imx7d";
 
+	aliases {
+		spi5 = &soft_spi;
+	};
+
 	memory {
 		reg = <0x80000000 0x80000000>;
 	};
 
-	spi4 {
+	soft_spi: soft-spi {
 		compatible = "spi-gpio";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_spi1>;
diff --git a/arch/arm/dts/imx7d.dtsi b/arch/arm/dts/imx7d.dtsi
index f6dee41..30b0589 100644
--- a/arch/arm/dts/imx7d.dtsi
+++ b/arch/arm/dts/imx7d.dtsi
@@ -86,6 +86,18 @@ 
 	};
 };
 
+&aips2 {
+	epdc: epdc@306f0000 {
+		compatible = "fsl,imx7d-epdc";
+		interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
+		reg = <0x306f0000 0x10000>;
+		clocks = <&clks IMX7D_CLK_DUMMY>, <&clks IMX7D_EPDC_PIXEL_ROOT_CLK>;
+		clock-names = "epdc_axi", "epdc_pix";
+		epdc-ram = <&gpr 0x4 30>;
+		status = "disabled";
+	};
+};
+
 &aips3 {
 	usbotg2: usb@30b20000 {
 		compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
diff --git a/arch/arm/dts/imx7s.dtsi b/arch/arm/dts/imx7s.dtsi
index a7d48e7..540de6c 100644
--- a/arch/arm/dts/imx7s.dtsi
+++ b/arch/arm/dts/imx7s.dtsi
@@ -81,10 +81,11 @@ 
 		serial4 = &uart5;
 		serial5 = &uart6;
 		serial6 = &uart7;
-		spi0 = &ecspi1;
-		spi1 = &ecspi2;
-		spi2 = &ecspi3;
-		spi3 = &ecspi4;
+		spi0 = &qspi1;
+		spi1 = &ecspi1;
+		spi2 = &ecspi2;
+		spi3 = &ecspi3;
+		spi4 = &ecspi4;
 	};
 
 	cpus {
@@ -966,6 +967,19 @@ 
 				status = "disabled";
 			};
 
+			qspi1: qspi@30bb0000 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "fsl,imx7d-qspi";
+				reg = <0x30bb0000 0x10000>, <0x60000000 0x10000000>;
+				reg-names = "QuadSPI", "QuadSPI-memory";
+				interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_QSPI_ROOT_CLK>,
+					<&clks IMX7D_QSPI_ROOT_CLK>;
+				clock-names = "qspi_en", "qspi";
+				status = "disabled";
+			};
+
 			sdma: sdma@30bd0000 {
 				compatible = "fsl,imx7d-sdma", "fsl,imx35-sdma";
 				reg = <0x30bd0000 0x10000>;
diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index 90e2d1a..191b59a 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -36,9 +36,6 @@  DECLARE_GLOBAL_DATA_PTR;
 #define LCD_PAD_CTRL    (PAD_CTL_HYS | PAD_CTL_PUS_PU100KOHM | \
 	PAD_CTL_DSE_3P3V_49OHM)
 
-#define QSPI_PAD_CTRL	\
-	(PAD_CTL_DSE_3P3V_49OHM | PAD_CTL_PUE | PAD_CTL_PUS_PU47KOHM)
-
 #define NAND_PAD_CTRL (PAD_CTL_DSE_3P3V_49OHM | PAD_CTL_SRE_SLOW | PAD_CTL_HYS)
 
 #define SPI_PAD_CTRL \
@@ -278,21 +275,8 @@  int board_phy_config(struct phy_device *phydev)
 #endif
 
 #ifdef CONFIG_FSL_QSPI
-static iomux_v3_cfg_t const quadspi_pads[] = {
-	MX7D_PAD_EPDC_DATA00__QSPI_A_DATA0 | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-	MX7D_PAD_EPDC_DATA01__QSPI_A_DATA1 | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-	MX7D_PAD_EPDC_DATA02__QSPI_A_DATA2 | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-	MX7D_PAD_EPDC_DATA03__QSPI_A_DATA3 | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-	MX7D_PAD_EPDC_DATA05__QSPI_A_SCLK  | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-	MX7D_PAD_EPDC_DATA06__QSPI_A_SS0_B | MUX_PAD_CTRL(QSPI_PAD_CTRL),
-};
-
 int board_qspi_init(void)
 {
-	/* Set the iomux */
-	imx_iomux_v3_setup_multiple_pads(quadspi_pads,
-					 ARRAY_SIZE(quadspi_pads));
-
 	/* Set the clock */
 	set_clk_qspi();
 
diff --git a/configs/mx7dsabresd_qspi_defconfig b/configs/mx7dsabresd_qspi_defconfig
new file mode 100644
index 0000000..a798804
--- /dev/null
+++ b/configs/mx7dsabresd_qspi_defconfig
@@ -0,0 +1,83 @@ 
+CONFIG_ARM=y
+CONFIG_ARCH_MX7=y
+CONFIG_SYS_TEXT_BASE=0x87800000
+CONFIG_TARGET_MX7DSABRESD=y
+CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
+# CONFIG_ARMV7_VIRT is not set
+CONFIG_IMX_RDC=y
+CONFIG_IMX_BOOTAUX=y
+# CONFIG_CMD_BMODE is not set
+CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb-qspi"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
+# CONFIG_CONSOLE_MUX is not set
+CONFIG_SYS_CONSOLE_IS_IN_ENV=y
+CONFIG_HUSH_PARSER=y
+# CONFIG_CMD_BOOTD is not set
+CONFIG_CMD_BOOTZ=y
+# CONFIG_CMD_IMI is not set
+# CONFIG_CMD_XIMG is not set
+# CONFIG_CMD_EXPORTENV is not set
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_DFU=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_BMP=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_OF_CONTROL=y
+CONFIG_DFU_MMC=y
+CONFIG_DFU_RAM=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_74X164=y
+CONFIG_DM_I2C=y
+CONFIG_DM_MMC=y
+CONFIG_MMC_IO_VOLTAGE=y
+CONFIG_MMC_UHS_SUPPORT=y
+CONFIG_MMC_HS200_SUPPORT=y
+CONFIG_FSL_ESDHC=y
+CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_EON=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_BAR=y
+CONFIG_PHYLIB=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX7=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_PFUZE100=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_PFUZE100=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SOFT_SPI=y
+CONFIG_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_MXC_USB_OTG_HACTIVE=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_USB_GADGET_VENDOR_NUM=0x0525
+CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
+CONFIG_CI_UDC=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_USB_HOST_ETHER=y
+CONFIG_USB_ETHER_ASIX=y
+CONFIG_VIDEO=y
+CONFIG_ERRNO_STR=y
diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h
index 87d2b52..3cd32ea 100644
--- a/include/configs/mx7dsabresd.h
+++ b/include/configs/mx7dsabresd.h
@@ -227,9 +227,7 @@ 
 #endif
 
 #ifdef CONFIG_FSL_QSPI
-#define CONFIG_SPI_FLASH
-#define CONFIG_SPI_FLASH_MACRONIX
-#define CONFIG_SPI_FLASH_BAR
+#define CONFIG_SYS_FSL_QSPI_AHB
 #define CONFIG_SF_DEFAULT_BUS		0
 #define CONFIG_SF_DEFAULT_CS		0
 #define CONFIG_SF_DEFAULT_SPEED		40000000