diff mbox

[U-Boot,2/3] serial: drop serial_register return value

Message ID 1304136211-1316-2-git-send-email-vapier@gentoo.org
State Accepted
Commit c52b4f794541c9aad15148ae8f4e1af775e3e776
Delegated to: Wolfgang Denk
Headers show

Commit Message

Mike Frysinger April 30, 2011, 4:03 a.m. UTC 
The serial_register function never fails (always return 0), so change it
to a void function to avoid wasting overhead on it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 common/serial.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Comments

Wolfgang Denk July 26, 2011, 2:38 p.m. UTC | #1 
Dear Mike Frysinger,

In message <1304136211-1316-2-git-send-email-vapier@gentoo.org> you wrote:
> The serial_register function never fails (always return 0), so change it
> to a void function to avoid wasting overhead on it.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/serial.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/common/serial.c b/common/serial.c
index 505c2c6..bf77409 100644
--- a/common/serial.c
+++ b/common/serial.c
@@ -30,7 +30,7 @@  DECLARE_GLOBAL_DATA_PTR;
 static struct serial_device *serial_devices = NULL;
 static struct serial_device *serial_current = NULL;
 
-int serial_register (struct serial_device *dev)
+void serial_register(struct serial_device *dev)
 {
 #ifdef CONFIG_NEEDS_MANUAL_RELOC
 	dev->init += gd->reloc_off;
@@ -43,8 +43,6 @@  int serial_register (struct serial_device *dev)
 
 	dev->next = serial_devices;
 	serial_devices = dev;
-
-	return 0;
 }
 
 void serial_initialize (void)