From patchwork Fri Apr 29 20:26:36 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 93474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3B83FB6F0A for ; Sat, 30 Apr 2011 06:26:37 +1000 (EST) Received: (qmail 4802 invoked by alias); 29 Apr 2011 20:26:35 -0000 Received: (qmail 4793 invoked by uid 22791); 29 Apr 2011 20:26:34 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Apr 2011 20:26:18 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p3TKQHuw020242 for ; Fri, 29 Apr 2011 13:26:17 -0700 Received: from gya6 (gya6.prod.google.com [10.243.49.6]) by wpaz21.hot.corp.google.com with ESMTP id p3TKP1QI002370 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 29 Apr 2011 13:26:16 -0700 Received: by gya6 with SMTP id 6so2073430gya.35 for ; Fri, 29 Apr 2011 13:26:16 -0700 (PDT) Received: by 10.147.27.31 with SMTP id e31mr1909790yaj.8.1304108776528; Fri, 29 Apr 2011 13:26:16 -0700 (PDT) Received: from [192.168.2.21] (CPE0026f3355b70-CM0026f3355b6d.cpe.net.cable.rogers.com [99.229.169.27]) by mx.google.com with ESMTPS id j3sm3114162anm.9.2011.04.29.13.26.15 (version=SSLv3 cipher=OTHER); Fri, 29 Apr 2011 13:26:15 -0700 (PDT) Message-ID: <4DBB1EFC.2060208@google.com> Date: Fri, 29 Apr 2011 16:26:36 -0400 From: Diego Novillo User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: Nathan Froyd CC: reply@codereview.appspotmail.com, lcwu@google.com, jason@redhat.com, joseph@codesourcery.com, gcc-patches@gcc.gnu.org Subject: Re: [google] Add new warning -Wreal-conversion (issue4436068) References: <20110429145931.E255FAE1DD@tobiano.tor.corp.google.com> <20110429150244.GW23480@codesourcery.com> In-Reply-To: <20110429150244.GW23480@codesourcery.com> X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 04/29/2011 11:02 AM, Nathan Froyd wrote: > On Fri, Apr 29, 2011 at 10:59:31AM -0400, Diego Novillo wrote: >> * g++.dg/warn/Wreal-conversion-1.C: New. >> * gcc.dg/Wreal-conversion-1.c: New. > > Could a single copy of the test be placed in c-c++-common, instead? > > -Nathan Committed to google/main 2011-04-29 Diego Novillo * c-c++-common/Wreal-conversion-1.c: Move from gcc.dg. * g++.dg/warn/Wreal-conversion-1.C: Remove. diff --git a/gcc/testsuite/c-c++-common/Wreal-conversion-1.c b/gcc/testsuite/c-c++-common/Wreal-conversion-1.c new file mode 100644 index 0000000..84e7293 --- /dev/null +++ b/gcc/testsuite/c-c++-common/Wreal-conversion-1.c @@ -0,0 +1,29 @@ +// { dg-do compile } +// { dg-options "-Wreal-conversion" } + +#include + +int +func1 (int a) +{ + double f = a; + return f; // { dg-warning "conversion to" } +} + +double func3 (); + +void +func2 () +{ + double g = 3.2; + float f; + int t = g; // { dg-warning "conversion to" } + int p; + p = f; // { dg-warning "conversion to" } + func1 (g); // { dg-warning "conversion to" } + char c = f; // { dg-warning "conversion to" } + size_t s; + p = s; + int q; + q = func3 (); // { dg-warning "conversion to" } +} diff --git a/gcc/testsuite/g++.dg/warn/Wreal-conversion-1.C b/gcc/testsuite/g++.dg/warn/Wreal-conversion-1.C deleted file mode 100644 index 2079486..0000000 --- a/gcc/testsuite/g++.dg/warn/Wreal-conversion-1.C +++ /dev/null @@ -1,30 +0,0 @@ -// { dg-do compile } -// { dg-options "-Wreal-conversion" } - -#include - -int -func1 (int a) -{ - double f = a; - return f; // { dg-warning "conversion to" } -} - -double func3 (); - -void -func2 () -{ - double g = 3.2; - float f; - int t = g; // { dg-warning "conversion to" } - bool b = g; - int p; - p = f; // { dg-warning "conversion to" } - func1 (g); // { dg-warning "conversion to" } - char c = f; // { dg-warning "conversion to" } - size_t s; - p = s; - int q; - q = func3 (); // { dg-warning "conversion to" } -} diff --git a/gcc/testsuite/gcc.dg/Wreal-conversion-1.c b/gcc/testsuite/gcc.dg/Wreal-conversion-1.c deleted file mode 100644 index 84e7293..0000000 --- a/gcc/testsuite/gcc.dg/Wreal-conversion-1.c +++ /dev/null @@ -1,29 +0,0 @@ -// { dg-do compile } -// { dg-options "-Wreal-conversion" } - -#include - -int -func1 (int a) -{ - double f = a; - return f; // { dg-warning "conversion to" } -} - -double func3 (); - -void -func2 () -{ - double g = 3.2; - float f; - int t = g; // { dg-warning "conversion to" } - int p; - p = f; // { dg-warning "conversion to" } - func1 (g); // { dg-warning "conversion to" } - char c = f; // { dg-warning "conversion to" } - size_t s; - p = s; - int q; - q = func3 (); // { dg-warning "conversion to" } -}