Patchwork [1/10] ipv4: Remove now superfluous code in ip_route_connect().

login
register
mail settings
Submitter David Miller
Date April 29, 2011, 5:26 p.m.
Message ID <20110429.102654.71099871.davem@davemloft.net>
Download mbox | patch
Permalink /patch/93458/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - April 29, 2011, 5:26 p.m.
Now that output route lookups update the flow with
source address et al. selections, the fl4->{saddr,daddr}
assignments here are no longer necessary.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/net/route.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/include/net/route.h b/include/net/route.h
index 81b6cf2..16eb59c 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -271,8 +271,6 @@  static inline struct rtable *ip_route_connect(struct flowi4 *fl4,
 		rt = __ip_route_output_key(net, fl4);
 		if (IS_ERR(rt))
 			return rt;
-		fl4->daddr = rt->rt_dst;
-		fl4->saddr = rt->rt_src;
 		ip_rt_put(rt);
 	}
 	security_sk_classify_flow(sk, flowi4_to_flowi(fl4));