diff mbox

[1/5] dccp: Mechanism to resolve CCID dependencies

Message ID 20081118050346.GA3846@gerrit.erg.abdn.ac.uk
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Gerrit Renker Nov. 18, 2008, 5:03 a.m. UTC 
| > +	list_for_each_entry(entry, fn_list, node)
| > +		if (entry->feat_num == feat_num && entry->is_local == is_local)
| > +			return entry;
| > +		else if (entry->feat_num > feat_num)
| > +			break;
| 
| Personally, I would have put braces around this basic block.
| 
If it is possible to modify without disturbance, I attach a patch for this and
have changed it in the test tree.

I have checked that making this change does not affect subsequent
patches - it works with either variant.

Comments

David Miller Nov. 20, 2008, 9:03 a.m. UTC | #1 
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 18 Nov 2008 06:03:47 +0100

> | > +	list_for_each_entry(entry, fn_list, node)
> | > +		if (entry->feat_num == feat_num && entry->is_local == is_local)
> | > +			return entry;
> | > +		else if (entry->feat_num > feat_num)
> | > +			break;
> | 
> | Personally, I would have put braces around this basic block.
> | 
> If it is possible to modify without disturbance, I attach a patch for this and
> have changed it in the test tree.
> 
> I have checked that making this change does not affect subsequent
> patches - it works with either variant.

Applied, thanks Gerrit.  Please give a signoff next time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -171,11 +171,12 @@  static struct dccp_feat_entry *dccp_feat
 {
 	struct dccp_feat_entry *entry;
 
-	list_for_each_entry(entry, fn_list, node)
+	list_for_each_entry(entry, fn_list, node) {
 		if (entry->feat_num == feat_num && entry->is_local == is_local)
 			return entry;
 		else if (entry->feat_num > feat_num)
 			break;
+	}
 	return NULL;
 }