[0/4] spice: fix locking

Submitted by Gerd Hoffmann on April 29, 2011, 9:38 a.m.

Details

Message ID 1304069912-21629-1-git-send-email-kraxel@redhat.com
State New
Headers show

Pull-request

git://anongit.freedesktop.org/spice/qemu spice.v34

Commit Message

Gerd Hoffmann April 29, 2011, 9:38 a.m.
Hi,

This patch series moves a bunch of work spice has to do from spice
server thread context to iothread context, which in turn allows to
drop the current locking mess as we don't touch qemu internals from
spice server thread any more.

A long-standing warning fix from Jes is included too.

cheers,
  Gerd

The following changes since commit 430a3c18064fd3c007048d757e8bd0fff45fcc99:

  configure: reenable opengl by default (2011-04-26 23:26:49 +0200)

are available in the git repository at:
  git://anongit.freedesktop.org/spice/qemu spice.v34

Gerd Hoffmann (3):
      spice: don't create updates in spice server context.
      spice: don't call displaystate callbacks from spice server context.
      spice: drop obsolete iothread locking

Jes Sorensen (1):
      Make spice dummy functions inline to fix calls not checking return values

 hw/qxl-render.c    |   25 ++++++++++----------
 hw/qxl.c           |   27 ++++++++++-----------
 ui/qemu-spice.h    |   12 ++++++++-
 ui/spice-display.c |   63 +++++++++++++++++++++++++++++++++-------------------
 ui/spice-display.h |   24 +++++++++++++++----
 5 files changed, 94 insertions(+), 57 deletions(-)

Comments

Alon Levy April 29, 2011, 11:20 a.m.
On Fri, Apr 29, 2011 at 11:38:28AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> This patch series moves a bunch of work spice has to do from spice
> server thread context to iothread context, which in turn allows to
> drop the current locking mess as we don't touch qemu internals from
> spice server thread any more.
> 
> A long-standing warning fix from Jes is included too.
> 

Tested with winxp, works well with changes between vga and qxl (tested
by setting the debug to 2 in spice-display.c). Just a single comment about
the debug=1 change in the second patch.

Alon

> cheers,
>   Gerd
> 
> The following changes since commit 430a3c18064fd3c007048d757e8bd0fff45fcc99:
> 
>   configure: reenable opengl by default (2011-04-26 23:26:49 +0200)
> 
> are available in the git repository at:
>   git://anongit.freedesktop.org/spice/qemu spice.v34
> 
> Gerd Hoffmann (3):
>       spice: don't create updates in spice server context.
>       spice: don't call displaystate callbacks from spice server context.
>       spice: drop obsolete iothread locking
> 
> Jes Sorensen (1):
>       Make spice dummy functions inline to fix calls not checking return values
> 
>  hw/qxl-render.c    |   25 ++++++++++----------
>  hw/qxl.c           |   27 ++++++++++-----------
>  ui/qemu-spice.h    |   12 ++++++++-
>  ui/spice-display.c |   63 +++++++++++++++++++++++++++++++++-------------------
>  ui/spice-display.h |   24 +++++++++++++++----
>  5 files changed, 94 insertions(+), 57 deletions(-)
>
Alon Levy April 29, 2011, 10:33 p.m.
On Fri, Apr 29, 2011 at 02:20:09PM +0300, Alon Levy wrote:
> On Fri, Apr 29, 2011 at 11:38:28AM +0200, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > This patch series moves a bunch of work spice has to do from spice
> > server thread context to iothread context, which in turn allows to
> > drop the current locking mess as we don't touch qemu internals from
> > spice server thread any more.
> > 
> > A long-standing warning fix from Jes is included too.
> > 
> 
> Tested with winxp, works well with changes between vga and qxl (tested
> by setting the debug to 2 in spice-display.c). Just a single comment about
> the debug=1 change in the second patch.
> 

Forgot:

ACK series

> Alon
> 
> > cheers,
> >   Gerd
> > 
> > The following changes since commit 430a3c18064fd3c007048d757e8bd0fff45fcc99:
> > 
> >   configure: reenable opengl by default (2011-04-26 23:26:49 +0200)
> > 
> > are available in the git repository at:
> >   git://anongit.freedesktop.org/spice/qemu spice.v34
> > 
> > Gerd Hoffmann (3):
> >       spice: don't create updates in spice server context.
> >       spice: don't call displaystate callbacks from spice server context.
> >       spice: drop obsolete iothread locking
> > 
> > Jes Sorensen (1):
> >       Make spice dummy functions inline to fix calls not checking return values
> > 
> >  hw/qxl-render.c    |   25 ++++++++++----------
> >  hw/qxl.c           |   27 ++++++++++-----------
> >  ui/qemu-spice.h    |   12 ++++++++-
> >  ui/spice-display.c |   63 +++++++++++++++++++++++++++++++++-------------------
> >  ui/spice-display.h |   24 +++++++++++++++----
> >  5 files changed, 94 insertions(+), 57 deletions(-)
> > 
>