| Message ID | 11b23b65581253f10905bcefc923aacb3c2ce85a.1529647987.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 5da7b8cb08dbae06bb11f72449d425fdc20d1f81 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] hush: Remove default CONFIG_SYS_PROMPT_HUSH_PS2 setting from board files | expand |
On 06/21/2018 11:13 PM, Michal Simek wrote: > There is no reason to define default option for this macro which is > already done in common/cli_hush.c. > > 86 #ifndef CONFIG_SYS_PROMPT_HUSH_PS2 > 87 #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " > 88 #endif > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > Reviewed-by: York Sun <york.sun@nxp.com>
On Fri, Jun 22, 2018 at 08:13:10AM +0200, Michal Simek wrote: > There is no reason to define default option for this macro which is > already done in common/cli_hush.c. > > 86 #ifndef CONFIG_SYS_PROMPT_HUSH_PS2 > 87 #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " > 88 #endif > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Reviewed-by: York Sun <york.sun@nxp.com> Applied to u-boot/master, thanks!
diff --git a/include/configs/ls1021aiot.h b/include/configs/ls1021aiot.h index 0c900eb1343d..97792be6a856 100644 --- a/include/configs/ls1021aiot.h +++ b/include/configs/ls1021aiot.h @@ -209,8 +209,6 @@ /* * Miscellaneous configurable options */ -#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " - #define CONFIG_CMD_GREPENV #define CONFIG_CMD_MEMINFO diff --git a/include/configs/ls1088a_common.h b/include/configs/ls1088a_common.h index c70474cdfacb..137a18121744 100644 --- a/include/configs/ls1088a_common.h +++ b/include/configs/ls1088a_common.h @@ -215,7 +215,6 @@ unsigned long long get_qixis_addr(void); #define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot args buffer */ #define CONFIG_SYS_MAXARGS 64 /* max command args */ diff --git a/include/configs/s32v234evb.h b/include/configs/s32v234evb.h index 48c979f97b92..c6fb909174db 100644 --- a/include/configs/s32v234evb.h +++ b/include/configs/s32v234evb.h @@ -148,7 +148,6 @@ #include <config_distro_bootcmd.h> /* Miscellaneous configurable options */ -#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " #define CONFIG_SYS_PROMPT "=> " #define CONFIG_SYS_MEMTEST_START (DDR_BASE_ADDR) diff --git a/include/configs/tplink_wdr4300.h b/include/configs/tplink_wdr4300.h index 0982d3e61184..436715824b23 100644 --- a/include/configs/tplink_wdr4300.h +++ b/include/configs/tplink_wdr4300.h @@ -44,7 +44,6 @@ #define CONFIG_SYS_MAXARGS 32 /* Max number of command args */ #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot argument buffer size */ -#define CONFIG_SYS_PROMPT_HUSH_PS2 "> " /* USB, USB storage, USB ethernet */ #define CONFIG_EHCI_MMIO_BIG_ENDIAN
There is no reason to define default option for this macro which is already done in common/cli_hush.c. 86 #ifndef CONFIG_SYS_PROMPT_HUSH_PS2 87 #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " 88 #endif Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- include/configs/ls1021aiot.h | 2 -- include/configs/ls1088a_common.h | 1 - include/configs/s32v234evb.h | 1 - include/configs/tplink_wdr4300.h | 1 - 4 files changed, 5 deletions(-)