| Message ID | 20180622051852.21840-1-jay.d.carlson@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,v2] arm, imx6: fix NOR/OneNAND boot mode mix-up | expand |
Hi Jay, On 22/06/2018 07:18, Jay Carlson wrote: > This patch fixes the ordering of the EMI enum to match Table 8-8 in > the i.MX6ULL Reference Manual, and has been spot-checked in two other > i.MX reference manuals for accuracy. > > Signed-off-by: Jay Carlson <jay.d.carlson@gmail.com> > --- > arch/arm/include/asm/mach-imx/sys_proto.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h > index d1d6cbc462..0acc3640f9 100644 > --- a/arch/arm/include/asm/mach-imx/sys_proto.h > +++ b/arch/arm/include/asm/mach-imx/sys_proto.h > @@ -63,8 +63,8 @@ enum imx6_bmode_serial_rom { > }; > > enum imx6_bmode_emi { > - IMX6_BMODE_ONENAND, > IMX6_BMODE_NOR, > + IMX6_BMODE_ONENAND > }; > I am not understanding which is the issue. The enum are just used in switch() section as far as I know, and then the order is not so important. Which is the issue / error you found ? Best regards, Stefano babic
diff --git a/arch/arm/include/asm/mach-imx/sys_proto.h b/arch/arm/include/asm/mach-imx/sys_proto.h index d1d6cbc462..0acc3640f9 100644 --- a/arch/arm/include/asm/mach-imx/sys_proto.h +++ b/arch/arm/include/asm/mach-imx/sys_proto.h @@ -63,8 +63,8 @@ enum imx6_bmode_serial_rom { }; enum imx6_bmode_emi { - IMX6_BMODE_ONENAND, IMX6_BMODE_NOR, + IMX6_BMODE_ONENAND }; enum imx6_bmode {
This patch fixes the ordering of the EMI enum to match Table 8-8 in the i.MX6ULL Reference Manual, and has been spot-checked in two other i.MX reference manuals for accuracy. Signed-off-by: Jay Carlson <jay.d.carlson@gmail.com> --- arch/arm/include/asm/mach-imx/sys_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)