Patchwork Fix typo in phys memory client registration path

login
register
mail settings
Submitter Alex Williamson
Date April 28, 2011, 7:43 p.m.
Message ID <20110428194025.32536.62624.stgit@s20.home>
Download mbox | patch
Permalink /patch/93281/
State New
Headers show

Comments

Alex Williamson - April 28, 2011, 7:43 p.m.
When we register a physical memory client, we try to walk the page
tables, calling the set_memory hook for every entry.  Effectively
playing catchup for the client for everything already registered.
This typo prevents us from walking most of the page tables.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

This seems right, but I'm not sure what kind of fallout we're
going to get in vhost.  kvm is the only other user of the phys
memory client interface, but it registers very early, so I don't
expect it to see much change.

 exec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/exec.c b/exec.c
index c037389..4752af1 100644
--- a/exec.c
+++ b/exec.c
@@ -1770,7 +1770,7 @@  static void phys_page_for_each(CPUPhysMemoryClient *client)
     int i;
     for (i = 0; i < P_L1_SIZE; ++i) {
         phys_page_for_each_1(client, P_L1_SHIFT / L2_BITS - 1,
-                             l1_phys_map + 1);
+                             l1_phys_map + i);
     }
 }