| Message ID | 1529527879-26495-2-git-send-email-michael@amarulasolutions.com |
|---|---|
| State | Accepted |
| Commit | 34ad74914140dc6060b56a27641c686e86d7a9a4 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot,1/3] spi: mxc: Fix compilation problem of DM_SPI class driver | expand |
> -----Original Message----- > From: Michael Trimarchi [mailto:michael@amarulasolutions.com] > Sent: 2018年6月21日 4:51 > To: Jagan Teki <jagan@openedev.com> > Cc: Stefano Babic <sbabic@denx.de>; Peng Fan <peng.fan@nxp.com>; > shyam.saini@amarulasolutions.com; u-boot@lists.denx.de > Subject: [PATCH 2/3] spi: mxc_spi: Fix chipselect on DM_SPI driver uclass > > CS GPIO activation low/high is determinated by the device tree so we don't > need to take in accoung in cs_activate and cs_deactivate Yes. > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- > drivers/spi/mxc_spi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index fcb214a..0dccc38 > 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -60,7 +60,7 @@ static inline struct mxc_spi_slave > *to_mxc_spi_slave(struct spi_slave *slave) static void > mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) { > if (CONFIG_IS_ENABLED(DM_SPI)) { > - dm_gpio_set_value(&mxcs->ss, mxcs->ss_pol); > + dm_gpio_set_value(&mxcs->ss, 1); > } else { > if (mxcs->gpio > 0) > gpio_set_value(mxcs->gpio, mxcs->ss_pol); @@ -70,7 +70,7 @@ > static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) static void > mxc_spi_cs_deactivate(struct mxc_spi_slave *mxcs) { > if (CONFIG_IS_ENABLED(DM_SPI)) { > - dm_gpio_set_value(&mxcs->ss, !(mxcs->ss_pol)); > + dm_gpio_set_value(&mxcs->ss, 0); > } else { > if (mxcs->gpio > 0) > gpio_set_value(mxcs->gpio, !(mxcs->ss_pol)); @@ -508,7 +508,7 > @@ static int mxc_spi_probe(struct udevice *bus) > if (plat->base == FDT_ADDR_T_NONE) > return -ENODEV; > > - ret = dm_gpio_set_value(&plat->ss, !(mxcs->ss_pol)); > + ret = dm_gpio_set_value(&plat->ss, 0); > if (ret) { > dev_err(bus, "Setting cs error\n"); > return ret; > -- Reviewed-by: Peng Fan <peng.fan@nxp.com> > 2.7.4
On Thu, Jun 21, 2018 at 2:21 AM, Michael Trimarchi <michael@amarulasolutions.com> wrote: > CS GPIO activation low/high is determinated by the device tree > so we don't need to take in accoung in cs_activate and cs_deactivate > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- Applied to u-boot-spi/master
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index fcb214a..0dccc38 100644 --- a/drivers/spi/mxc_spi.c +++ b/drivers/spi/mxc_spi.c @@ -60,7 +60,7 @@ static inline struct mxc_spi_slave *to_mxc_spi_slave(struct spi_slave *slave) static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) { if (CONFIG_IS_ENABLED(DM_SPI)) { - dm_gpio_set_value(&mxcs->ss, mxcs->ss_pol); + dm_gpio_set_value(&mxcs->ss, 1); } else { if (mxcs->gpio > 0) gpio_set_value(mxcs->gpio, mxcs->ss_pol); @@ -70,7 +70,7 @@ static void mxc_spi_cs_activate(struct mxc_spi_slave *mxcs) static void mxc_spi_cs_deactivate(struct mxc_spi_slave *mxcs) { if (CONFIG_IS_ENABLED(DM_SPI)) { - dm_gpio_set_value(&mxcs->ss, !(mxcs->ss_pol)); + dm_gpio_set_value(&mxcs->ss, 0); } else { if (mxcs->gpio > 0) gpio_set_value(mxcs->gpio, !(mxcs->ss_pol)); @@ -508,7 +508,7 @@ static int mxc_spi_probe(struct udevice *bus) if (plat->base == FDT_ADDR_T_NONE) return -ENODEV; - ret = dm_gpio_set_value(&plat->ss, !(mxcs->ss_pol)); + ret = dm_gpio_set_value(&plat->ss, 0); if (ret) { dev_err(bus, "Setting cs error\n"); return ret;
CS GPIO activation low/high is determinated by the device tree so we don't need to take in accoung in cs_activate and cs_deactivate Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> --- drivers/spi/mxc_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)