| Message ID | 1529527879-26495-1-git-send-email-michael@amarulasolutions.com |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot,1/3] spi: mxc: Fix compilation problem of DM_SPI class driver | expand |
On Wed, Jun 20, 2018 at 5:51 PM, Michael Trimarchi <michael@amarulasolutions.com> wrote: > drivers/spi/mxc_spi.c:507: undefined reference to `dev_get_addr' > linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> Yes, this has been reported before. Thanks for fixing it: Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> -----Original Message----- > From: Michael Trimarchi [mailto:michael@amarulasolutions.com] > Sent: 2018年6月21日 4:51 > To: Jagan Teki <jagan@openedev.com> > Cc: Stefano Babic <sbabic@denx.de>; Peng Fan <peng.fan@nxp.com>; > shyam.saini@amarulasolutions.com; u-boot@lists.denx.de > Subject: [PATCH 1/3] spi: mxc: Fix compilation problem of DM_SPI class driver > > drivers/spi/mxc_spi.c:507: undefined reference to `dev_get_addr' > linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- > drivers/spi/mxc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index b77129c..fcb214a > 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -504,7 +504,7 @@ static int mxc_spi_probe(struct udevice *bus) > return -EINVAL; > } > > - plat->base = dev_get_addr(bus); > + plat->base = devfdt_get_addr(bus); > if (plat->base == FDT_ADDR_T_NONE) > return -ENODEV; Reviewed-by: Peng Fan <peng.fan@nxp.com> > > -- > 2.7.4
On Thu, Jun 21, 2018 at 2:21 AM, Michael Trimarchi <michael@amarulasolutions.com> wrote: > drivers/spi/mxc_spi.c:507: undefined reference to `dev_get_addr' > linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> > --- Applied to u-boot-spi/master
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c index b77129c..fcb214a 100644 --- a/drivers/spi/mxc_spi.c +++ b/drivers/spi/mxc_spi.c @@ -504,7 +504,7 @@ static int mxc_spi_probe(struct udevice *bus) return -EINVAL; } - plat->base = dev_get_addr(bus); + plat->base = devfdt_get_addr(bus); if (plat->base == FDT_ADDR_T_NONE) return -ENODEV;
drivers/spi/mxc_spi.c:507: undefined reference to `dev_get_addr' linux-ld.bfd: BFD (GNU Binutils) 2.29.1 assertion fail elf32-arm.c:9509 Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com> --- drivers/spi/mxc_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)