From patchwork Wed Jun 20 07:44:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 932005 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="JMVlo7cG"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 419cLY26ykz9s2R for ; Wed, 20 Jun 2018 17:45:09 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id A374FF48; Wed, 20 Jun 2018 07:45:07 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 9609EEFF for ; Wed, 20 Jun 2018 07:45:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 27050E6 for ; Wed, 20 Jun 2018 07:45:05 +0000 (UTC) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180620074503euoutp02eb764e13ecb6b59bb6d7bfd3eab2e656~5zpim9d202049320493euoutp02e; Wed, 20 Jun 2018 07:45:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180620074503euoutp02eb764e13ecb6b59bb6d7bfd3eab2e656~5zpim9d202049320493euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1529480703; bh=xgEizmoN8pdgZchMzIAlTMn94j/DO+JBDGf/RFDJLlQ=; h=From:To:Cc:Subject:Date:References:From; b=JMVlo7cGOGlJz8629MleWPX6KWvHRZosMK9R+6SqAtGlib8nP1NJq0YWbY4VJgIKy EVmXha99q58yY7krrVyCQgxeNPGXCNz+BhMNYZrV3tZh63Jft2o3lRhloc+B6A8cw8 iazb20avW1yOAABfhjeZpbBmWOR8uomvACDfN8Vw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180620074503eucas1p2dc20a54cfc57a277d901f958d5de3c44~5zpiNf6jL1793417934eucas1p2I; Wed, 20 Jun 2018 07:45:03 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 05.BA.17380.DF50A2B5; Wed, 20 Jun 2018 08:45:02 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180620074501eucas1p2de9ca068982a2f4d231d110aa8b3cd56~5zpgtSBPm1980719807eucas1p2r; Wed, 20 Jun 2018 07:45:01 +0000 (GMT) X-AuditID: cbfec7f4-6f9ff700000043e4-d3-5b2a05fd5bb7 Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E1.5E.04183.DF50A2B5; Wed, 20 Jun 2018 08:45:01 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PAM00BHX2UU8720@eusync1.samsung.com>; Wed, 20 Jun 2018 08:45:01 +0100 (BST) From: Ilya Maximets To: ovs-dev@openvswitch.org, Ben Pfaff Date: Wed, 20 Jun 2018 10:44:51 +0300 Message-id: <1529480691-22830-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42LZduzned1/rFrRBku2M1q8mtzAaHGl/Se7 xdxPzxktPu7ez+jA4rFz1l12j2c3/zN6PL/Ww+LRt2UVYwBLFJdNSmpOZllqkb5dAlfG5LmV BR95Knpe9LA3MK7h6mLk5JAQMJH40f6QGcQWEljBKPF+k10XIxeQ/ZlR4uyTO4wwRUc/LWCF SCxjlGie1sQM4TQzSez78BKsnU1AR+LU6iNgHSJAHcumfmMDsZkFPCRap75mB7GFBXwk3u09 AhZnEVCVuNO7GczmFXCTuHP2FhvENjmJm+c6wRZICJxllTjVdpMVIuEisb1/OjuELSzx6vgW KFtG4vLkbhYIu17ifstLRojmDkaJ6Yf+MUEk7CW2vD7HDnERn8SkbdOBNnAAxXklOtqEIEwP iSnra0FMIYFYiTn/nCYwSixgZFjFKJ5aWpybnlpslJdarlecmFtcmpeul5yfu4kRGDun/x3/ soNx15+kQ4wCHIxKPLwMzJrRQqyJZcWVuYcYJTiYlUR4GU5pRAvxpiRWVqUW5ccXleakFh9i lOZgURLnjdOoixISSE8sSc1OTS1ILYLJMnFwSjUwCm9cd+XxVrnYrulVxyNyec4I3AtKSbKN D0kMvct675E5s+2R65N5OA7tm2kqMj0nZPtSW/138ZM5nnX/n+7lcrpTpt3kaI5mebrIFYUj 1yzOnl8+pbs4p+qx4MqvZpuOuF5REHA67l7d7/osJi3UWqR2yp2g5vfuZpWtvW+zo9tqnZZU bLmixFKckWioxVxUnAgA/D8KkJkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNJMWRmVeSWpSXmKPExsVy+t/xy7p/WbWiDa7PkrJ4NbmB0eJK+092 i7mfnjNafNy9n9GBxWPnrLvsHs9u/mf0eH6th8Wjb8sqxgCWKC6blNSczLLUIn27BK6MyXMr Cz7yVPS86GFvYFzD1cXIySEhYCJx9NMC1i5GLg4hgSWMEmtfr2SBcFqZJI69n8sCUsUmoCNx avURRhBbBKhj2dRvbCA2s4CHROvU1+wgtrCAj8S7vUfA4iwCqhJ3ejeD2bwCbhJ3zt5ig9gm J3HzXCfzBEauBYwMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQK9vO3Yzy07GLveBR9iFOBg VOLhZWDWjBZiTSwrrsw9xCjBwawkwstwSiNaiDclsbIqtSg/vqg0J7X4EKM0B4uSOO95g8oo IYH0xJLU7NTUgtQimCwTB6dUAyP3+zUZFwQu6DjtfWw1P/bDdfe5q9ICzgTqms1Ll/t0OvKd zGLzCRt35RuoLpVra/4ldaJMoNSwzGbGj6QzG9mNbh/t1hPasXjzg/MypVuj3rHeZP+7scx4 Z4rzhzVrF5VOaZjCE6L90i3H/fKs3KYfAWKhe6s2v33mpP/rcDPL3diI0JCvMYlKLMUZiYZa zEXFiQC4kw7O7gEAAA== X-CMS-MailID: 20180620074501eucas1p2de9ca068982a2f4d231d110aa8b3cd56 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180620074501eucas1p2de9ca068982a2f4d231d110aa8b3cd56 References: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Ilya Maximets Subject: [ovs-dev] [PATCH] rconn: Suppress 'connected' log for unreliable connections. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Recent assertion failure fix changed rconn workflow for unreliable connections (such as connections from ovs-ofctl) from |rconn|DBG|br-int<->unix#151: entering ACTIVE |rconn|DBG|br-int<->unix#151: connection closed by peer |rconn|DBG|br-int<->unix#151: entering DISCONNECTED To |rconn|DBG|br-int<->unix#200: entering CONNECTING |rconn|INFO|br-int<->unix#200: connected |rconn|DBG|br-int<->unix#200: entering ACTIVE |rconn|DBG|br-int<->unix#200: connection closed by peer |rconn|DBG|br-int<->unix#200: entering DISCONNECTED Many monitoring/configuring tools (ex. ovs-neutron-agent) uses ovs-ofctl frequently to check the statuses of installed flows. This produces a lot of "connected" logs, that are useless in general. Fix that by changing the log level to DBG for unreliable connections. Suggested-by: Ben Pfaff Fixes: c9a9b9b00bf5 ("rconn: Introduce new invariant to fix assertion failure in corner case.") Signed-off-by: Ilya Maximets --- lib/rconn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rconn.c b/lib/rconn.c index 7af4e73..ece8769 100644 --- a/lib/rconn.c +++ b/lib/rconn.c @@ -511,7 +511,7 @@ run_CONNECTING(struct rconn *rc) { int retval = vconn_connect(rc->vconn); if (!retval) { - VLOG_INFO("%s: connected", rc->name); + VLOG(rc->reliable ? VLL_INFO : VLL_DBG, "%s: connected", rc->name); rc->n_successful_connections++; state_transition(rc, S_ACTIVE); rc->version = vconn_get_version(rc->vconn);