diff mbox series

[Bug,1777786,NEW] virtio-gpu-3d.c: change virtio_gpu_fence_poll timer scale

Message ID 152947832268.7374.8550233006013647387.malonedeb@wampee.canonical.com
State New
Headers show
Series [Bug,1777786,NEW] virtio-gpu-3d.c: change virtio_gpu_fence_poll timer scale | expand

Commit Message

Launchpad Bug Tracker June 20, 2018, 7:05 a.m. UTC 
Public bug reported:

We use virtio-gpu to accelerate Unigine Heaven Benchmark in VM. But we get only 5 FPS when we use AMD RX460 in our host.
We found that guest os spent a lot of time in waiting for the return of glMapBufferRange/glUnmapBuffer commad. We suspected the host GPU was waiting for fence. So we finally change the timer of fence_poll. Afer change timer from
 ms to us， Benchmark result raise up to 22 FPS.

>From a4003af5c4fe92d55353f42767d0c45de95bb78f Mon Sep 17 00:00:00 2001
From: chen wei <chenwei1@ruijie.com.cn>
Date: Fri, 8 Jun 2018 17:34:45 +0800
Subject: [PATCH] virtio-gpu:improve 3d performance greatly

  opengl function need fence support.when CPU execute opengl function, it need wait fence for synchronize GPU.
so qemu must deal with fence timely as possible. but now the expire time of the timer to deal with fence is 10 ms.
I think it is too long for opengl. So i will change it to 20 ns.
  Before change, when i play Unigine_Heaven 3d game with virglrenderer, the fps is 3.  atfer change the fps up to 23.

Signed-off-by: chen wei   <chenwei1@ruijie.com.cn>
Signed-off-by: wang qiang <qiang_w@ruijie.com.cn>
---
 hw/display/virtio-gpu-3d.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Launchpad Bug Tracker June 20, 2018, 9:03 a.m. UTC | #1 
Please don't use the bug tracker for providing patches, and send it to
the mailing list instead, see:
https://wiki.qemu.org/Contribute/SubmitAPatch
Launchpad Bug Tracker Nov. 24, 2020, 4:43 p.m. UTC | #2 
Did you ever send your patch to the mailing list for discussion?

** Changed in: qemu
       Status: New => Incomplete
Launchpad Bug Tracker Jan. 24, 2021, 4:17 a.m. UTC | #3 
[Expired for QEMU because there has been no activity for 60 days.]

** Changed in: qemu
       Status: Incomplete => Expired
diff mbox series

Patch

diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index 3558f38..c0a5d21 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -582,7 +582,7 @@  static void virtio_gpu_fence_poll(void *opaque)
     virgl_renderer_poll();
     virtio_gpu_process_cmdq(g);
     if (!QTAILQ_EMPTY(&g->cmdq) || !QTAILQ_EMPTY(&g->fenceq)) {
-        timer_mod(g->fence_poll, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + 10);
+        timer_mod(g->fence_poll, qemu_clock_get_us(QEMU_CLOCK_VIRTUAL) + 20);
     }
 }
 
@@ -629,7 +629,7 @@  int virtio_gpu_virgl_init(VirtIOGPU *g)
         return ret;
     }
 
-    g->fence_poll = timer_new_ms(QEMU_CLOCK_VIRTUAL,
+    g->fence_poll = timer_new_us(QEMU_CLOCK_VIRTUAL,
                                  virtio_gpu_fence_poll, g);
 
     if (virtio_gpu_stats_enabled(g->conf)) {