| Message ID | 20180618203750.28658-2-johannes@sipsolutions.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v4,1/3] bitfield: fix *_encode_bits() | expand |
On Mon, Jun 18, 2018 at 11:37 PM, Johannes Berg <johannes@sipsolutions.net> wrote: > There's no reason why we shouldn't pack/unpack bits into/from > u8 values/registers/etc., so add u8 helpers. > > Use the ____MAKE_OP() macro directly to avoid having nonsense > le8_encode_bits() and similar functions. > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> > --- > include/linux/bitfield.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h > index 147a7bb341dd..65a6981eef7b 100644 > --- a/include/linux/bitfield.h > +++ b/include/linux/bitfield.h > @@ -143,6 +143,7 @@ static __always_inline base type##_get_bits(__##type v, base field) \ > ____MAKE_OP(le##size,u##size,cpu_to_le##size,le##size##_to_cpu) \ > ____MAKE_OP(be##size,u##size,cpu_to_be##size,be##size##_to_cpu) \ > ____MAKE_OP(u##size,u##size,,) > +____MAKE_OP(u8,u8,,) > __MAKE_OP(16) > __MAKE_OP(32) > __MAKE_OP(64) > -- > 2.14.4 >
diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 147a7bb341dd..65a6981eef7b 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h @@ -143,6 +143,7 @@ static __always_inline base type##_get_bits(__##type v, base field) \ ____MAKE_OP(le##size,u##size,cpu_to_le##size,le##size##_to_cpu) \ ____MAKE_OP(be##size,u##size,cpu_to_be##size,be##size##_to_cpu) \ ____MAKE_OP(u##size,u##size,,) +____MAKE_OP(u8,u8,,) __MAKE_OP(16) __MAKE_OP(32) __MAKE_OP(64)
There's no reason why we shouldn't pack/unpack bits into/from u8 values/registers/etc., so add u8 helpers. Use the ____MAKE_OP() macro directly to avoid having nonsense le8_encode_bits() and similar functions. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> --- include/linux/bitfield.h | 1 + 1 file changed, 1 insertion(+)