From patchwork Wed Apr 27 20:24:21 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Add new -gmlt option for min. debug info with line tables
 (issue4440072)
From: Cary Coutant <ccoutant@google.com>
X-Patchwork-Id: 93116
Message-Id: <BANLkTi=pHmvoK3vXdrcM6m5=vOm5OrRASw@mail.gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: reply@codereview.appspotmail.com, jason@redhat.com, gcc-patches@gcc.gnu.org
Date: Wed, 27 Apr 2011 13:24:21 -0700

>> set_debug_level should not use global state; this needs to check
>> opts->x_debug_info_level (not the global debug_info_level) and set
>> opts->x_generate_debug_line_table.
>
> Oops, missed that. Thanks!

I've uploaded the revised patch to
http://codereview.appspot.com/4440072 -- should I also post it here?

Here's the incremental diff...

-cary

 /* Arrange to dump core on error for diagnostic context DC.  (The


diff --git a/gcc/opts.c b/gcc/opts.c
index 72f4d51..ee8c2b0 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -1872,7 +1872,8 @@ set_debug_level (enum debug_info_type type, int
extended, const char *arg,
        opts->x_debug_info_level = (enum debug_info_levels) argval;
     }

-  generate_debug_line_table = debug_info_level >= DINFO_LEVEL_NORMAL;
+  opts->x_generate_debug_line_table = (opts->x_debug_info_level
+                                      >= DINFO_LEVEL_NORMAL);
 }