Patchwork Add new -gmlt option for min. debug info with line tables (issue4440072)

login
register
mail settings
Submitter Cary Coutant
Date April 27, 2011, 8:24 p.m.
Message ID <BANLkTi=pHmvoK3vXdrcM6m5=vOm5OrRASw@mail.gmail.com>
Download mbox | patch
Permalink /patch/93116/
State New
Headers show

Comments

Cary Coutant - April 27, 2011, 8:24 p.m.
>> set_debug_level should not use global state; this needs to check
>> opts->x_debug_info_level (not the global debug_info_level) and set
>> opts->x_generate_debug_line_table.
>
> Oops, missed that. Thanks!

I've uploaded the revised patch to
http://codereview.appspot.com/4440072 -- should I also post it here?

Here's the incremental diff...

-cary

 /* Arrange to dump core on error for diagnostic context DC.  (The
Cary Coutant - April 29, 2011, 8:36 p.m.
I'd like to put this patch into google/main while it's being reviewed for trunk.

Original message: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02075.html

Rietveld: http://codereview.appspot.com/4440072

Bootstraps on x86_64, with testsuite output identical to a vanilla build.

OK for google/main?

-cary
Diego Novillo - April 29, 2011, 8:40 p.m.
On Wed, Apr 27, 2011 at 16:24, Cary Coutant <ccoutant@google.com> wrote:
>>> set_debug_level should not use global state; this needs to check
>>> opts->x_debug_info_level (not the global debug_info_level) and set
>>> opts->x_generate_debug_line_table.
>>
>> Oops, missed that. Thanks!
>
> I've uploaded the revised patch to
> http://codereview.appspot.com/4440072 -- should I also post it here?

Yeah, not everyone on the list is using the web interface.


Diego.
Diego Novillo - April 29, 2011, 8:41 p.m.
On Fri, Apr 29, 2011 at 16:36, Cary Coutant <ccoutant@google.com> wrote:
> I'd like to put this patch into google/main while it's being reviewed for trunk.
>
> Original message: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02075.html
>
> Rietveld: http://codereview.appspot.com/4440072
>
> Bootstraps on x86_64, with testsuite output identical to a vanilla build.
>
> OK for google/main?

Yes.


Diego.
Cary Coutant - April 30, 2011, 12:09 a.m.
>> OK for google/main?
>
> Yes.

Thanks, committed to google/main.

-cary

Patch

diff --git a/gcc/opts.c b/gcc/opts.c
index 72f4d51..ee8c2b0 100644
--- a/gcc/opts.c
+++ b/gcc/opts.c
@@ -1872,7 +1872,8 @@  set_debug_level (enum debug_info_type type, int
extended, const char *arg,
        opts->x_debug_info_level = (enum debug_info_levels) argval;
     }

-  generate_debug_line_table = debug_info_level >= DINFO_LEVEL_NORMAL;
+  opts->x_generate_debug_line_table = (opts->x_debug_info_level
+                                      >= DINFO_LEVEL_NORMAL);
 }