diff mbox series

acpica: fix linking issues when building non ACPI builds

Message ID 20180618172621.31795-1-colin.king@canonical.com
State Accepted
Headers show
Series acpica: fix linking issues when building non ACPI builds | expand

Commit Message

Colin Ian King June 18, 2018, 5:26 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

It appears that building with older versions of gcc with ACPI disabled
causes a linking problem as the symbol AcpiGbl_VerboseHandlers is
not available.  The current workaround defines it as a unsigned char
type (same as ACPI's BOOLEAN) even though we never actually use it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpica/fwts_acpica.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alex Hung June 19, 2018, 12:57 a.m. UTC | #1 
On 2018-06-18 10:26 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> It appears that building with older versions of gcc with ACPI disabled
> causes a linking problem as the symbol AcpiGbl_VerboseHandlers is
> not available.  The current workaround defines it as a unsigned char
> type (same as ACPI's BOOLEAN) even though we never actually use it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/acpica/fwts_acpica.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index f4c45c6f..d985e18a 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1369,5 +1369,6 @@ VOID_FUNC(MpSaveSerialInfo)
>    * when building with ACPI disabled and I have no idea why.
>    */
>   unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
> +unsigned char AcpiGbl_VerboseHandlers = FALSE;
>   
>   #endif
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu June 19, 2018, 3:03 a.m. UTC | #2 
On 06/19/2018 01:26 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> It appears that building with older versions of gcc with ACPI disabled
> causes a linking problem as the symbol AcpiGbl_VerboseHandlers is
> not available.  The current workaround defines it as a unsigned char
> type (same as ACPI's BOOLEAN) even though we never actually use it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/fwts_acpica.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
> index f4c45c6f..d985e18a 100644
> --- a/src/acpica/fwts_acpica.c
> +++ b/src/acpica/fwts_acpica.c
> @@ -1369,5 +1369,6 @@ VOID_FUNC(MpSaveSerialInfo)
>   * when building with ACPI disabled and I have no idea why.
>   */
>  unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
> +unsigned char AcpiGbl_VerboseHandlers = FALSE;
>  
>  #endif
Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
index f4c45c6f..d985e18a 100644
--- a/src/acpica/fwts_acpica.c
+++ b/src/acpica/fwts_acpica.c
@@ -1369,5 +1369,6 @@  VOID_FUNC(MpSaveSerialInfo)
  * when building with ACPI disabled and I have no idea why.
  */
 unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
+unsigned char AcpiGbl_VerboseHandlers = FALSE;
 
 #endif