Patchwork [PULL] Request for Pull

login
register
mail settings
Submitter jvrao
Date April 27, 2011, 4:16 p.m.
Message ID <4DB84170.4010208@linux.vnet.ibm.com>
Download mbox
Permalink /patch/93089/
State New
Headers show

Pull-request

git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony

Comments

jvrao - April 27, 2011, 4:16 p.m.
The following changes since commit 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
   Jan Kiszka (1):
         pflash: Restore & fix lazy ROMD switching

are available in the git repository at:

   git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony

Aneesh Kumar K.V (3):
       virtio-9p: move 9p files around
       virtio-9p: Print the pdu details on return
       virtio-9p: removexattr on default acl should return 0

Harsh Prateek Bora (2):
       hw/virtio-9p-local.c: Remove unnecessary null char in symlink file
       v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.

M. Mohan Kumar (1):
       virtio-9p: Bugfix to send correct iounit

Stefan Hajnoczi (1):
       vl.c: Replace -virtfs string manipulation with QemuOpts

  Makefile.objs                        |   10 ++++--
  Makefile.target                      |    6 ++-
  configure                            |    2 +
  {hw => fsdev}/file-op-9p.h           |    0
  fsdev/qemu-fsdev.h                   |    2 +-
  hw/{ => 9pfs}/virtio-9p-debug.c      |    0
  hw/{ => 9pfs}/virtio-9p-debug.h      |    0
  hw/{ => 9pfs}/virtio-9p-local.c      |    2 +-
  hw/{ => 9pfs}/virtio-9p-posix-acl.c  |   17 ++++++++--
  hw/{ => 9pfs}/virtio-9p-xattr-user.c |    2 +-
  hw/{ => 9pfs}/virtio-9p-xattr.c      |    2 +-
  hw/{ => 9pfs}/virtio-9p-xattr.h      |    0
  hw/{ => 9pfs}/virtio-9p.c            |   14 ++++++--
  hw/{ => 9pfs}/virtio-9p.h            |    4 +-
  vl.c                                 |   56 
+++++++++++----------------------
  15 files changed, 62 insertions(+), 55 deletions(-)
  rename {hw => fsdev}/file-op-9p.h (100%)
  rename hw/{ => 9pfs}/virtio-9p-debug.c (100%)
  rename hw/{ => 9pfs}/virtio-9p-debug.h (100%)
  rename hw/{ => 9pfs}/virtio-9p-local.c (99%)
  rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%)
  rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%)
  rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%)
  rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%)
  rename hw/{ => 9pfs}/virtio-9p.c (99%)
  rename hw/{ => 9pfs}/virtio-9p.h (99%)
Anthony Liguori - April 28, 2011, 1:56 p.m.
On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote:
> The following changes since commit
> 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
> Jan Kiszka (1):
> pflash: Restore & fix lazy ROMD switching
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony

Pulled. Thanks.

Regards,

Anthony Liguori

> Aneesh Kumar K.V (3):
> virtio-9p: move 9p files around
> virtio-9p: Print the pdu details on return
> virtio-9p: removexattr on default acl should return 0
>
> Harsh Prateek Bora (2):
> hw/virtio-9p-local.c: Remove unnecessary null char in symlink file
> v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.
>
> M. Mohan Kumar (1):
> virtio-9p: Bugfix to send correct iounit
>
> Stefan Hajnoczi (1):
> vl.c: Replace -virtfs string manipulation with QemuOpts
>
> Makefile.objs | 10 ++++--
> Makefile.target | 6 ++-
> configure | 2 +
> {hw => fsdev}/file-op-9p.h | 0
> fsdev/qemu-fsdev.h | 2 +-
> hw/{ => 9pfs}/virtio-9p-debug.c | 0
> hw/{ => 9pfs}/virtio-9p-debug.h | 0
> hw/{ => 9pfs}/virtio-9p-local.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 17 ++++++++--
> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-xattr.h | 0
> hw/{ => 9pfs}/virtio-9p.c | 14 ++++++--
> hw/{ => 9pfs}/virtio-9p.h | 4 +-
> vl.c | 56 +++++++++++----------------------
> 15 files changed, 62 insertions(+), 55 deletions(-)
> rename {hw => fsdev}/file-op-9p.h (100%)
> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%)
> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%)
> rename hw/{ => 9pfs}/virtio-9p-local.c (99%)
> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%)
> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%)
> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%)
> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%)
> rename hw/{ => 9pfs}/virtio-9p.c (99%)
> rename hw/{ => 9pfs}/virtio-9p.h (99%)
>
>
>
Stefan Weil - April 28, 2011, 5:21 p.m.
Am 28.04.2011 15:56, schrieb Anthony Liguori:
> On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote:
>> The following changes since commit
>> 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
>> Jan Kiszka (1):
>> pflash: Restore & fix lazy ROMD switching
>>
>> are available in the git repository at:
>>
>> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony
>
> Pulled. Thanks.
>
> Regards,
>
> Anthony Liguori


This pull breaks compilation and linkage of latest QEMU:

* Compilation fails because of wrong include paths (caused by moved files).
   I just sent a patch to fix this issue.

* The linker fails for all system emulations without virtio. Example:

LINK  cris-softmmu/qemu-system-cris
../fsdev/qemu-fsdev.o:(.data+0xc): undefined reference to `local_ops'

I could add virtio to all these emulations, but I think a better solution
is required.

Regards,

Stefan Weil
Anthony Liguori - April 28, 2011, 5:39 p.m.
On 04/28/2011 12:21 PM, Stefan Weil wrote:
> Am 28.04.2011 15:56, schrieb Anthony Liguori:
>> On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote:
>>> The following changes since commit
>>> 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
>>> Jan Kiszka (1):
>>> pflash: Restore & fix lazy ROMD switching
>>>
>>> are available in the git repository at:
>>>
>>> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony
>>
>> Pulled. Thanks.
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> This pull breaks compilation and linkage of latest QEMU:
>
> * Compilation fails because of wrong include paths (caused by moved files).
> I just sent a patch to fix this issue.
>
> * The linker fails for all system emulations without virtio. Example:
>
> LINK cris-softmmu/qemu-system-cris
> ../fsdev/qemu-fsdev.o:(.data+0xc): undefined reference to `local_ops'

The use of CONFIG_REALLY_VIRTFS was wrong in the rename patch.  I'll 
push a fix.

Regards,

Anthony Liguori

>
> I could add virtio to all these emulations, but I think a better solution
> is required.
>
> Regards,
>
> Stefan Weil
>
>
Anthony Liguori - April 28, 2011, 5:46 p.m.
On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote:
> The following changes since commit
> 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
> Jan Kiszka (1):
> pflash: Restore & fix lazy ROMD switching
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony

It's pretty clear this pull request was done without doing a full build 
before hand.

I don't mean to single you out JV, but this happens too frequently with 
pull requests so let me be clear about this.

If you send me a pull request, you must do a FULL build before hand. 
That means not specifying a '--target-list' parameter.

Regards,

Anthony Liguori

>
> Aneesh Kumar K.V (3):
> virtio-9p: move 9p files around
> virtio-9p: Print the pdu details on return
> virtio-9p: removexattr on default acl should return 0
>
> Harsh Prateek Bora (2):
> hw/virtio-9p-local.c: Remove unnecessary null char in symlink file
> v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.
>
> M. Mohan Kumar (1):
> virtio-9p: Bugfix to send correct iounit
>
> Stefan Hajnoczi (1):
> vl.c: Replace -virtfs string manipulation with QemuOpts
>
> Makefile.objs | 10 ++++--
> Makefile.target | 6 ++-
> configure | 2 +
> {hw => fsdev}/file-op-9p.h | 0
> fsdev/qemu-fsdev.h | 2 +-
> hw/{ => 9pfs}/virtio-9p-debug.c | 0
> hw/{ => 9pfs}/virtio-9p-debug.h | 0
> hw/{ => 9pfs}/virtio-9p-local.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 17 ++++++++--
> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +-
> hw/{ => 9pfs}/virtio-9p-xattr.h | 0
> hw/{ => 9pfs}/virtio-9p.c | 14 ++++++--
> hw/{ => 9pfs}/virtio-9p.h | 4 +-
> vl.c | 56 +++++++++++----------------------
> 15 files changed, 62 insertions(+), 55 deletions(-)
> rename {hw => fsdev}/file-op-9p.h (100%)
> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%)
> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%)
> rename hw/{ => 9pfs}/virtio-9p-local.c (99%)
> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%)
> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%)
> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%)
> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%)
> rename hw/{ => 9pfs}/virtio-9p.c (99%)
> rename hw/{ => 9pfs}/virtio-9p.h (99%)
>
>
jvrao - May 2, 2011, 3:55 p.m.
On 04/28/2011 10:46 AM, Anthony Liguori wrote:
> On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote:
>> The following changes since commit
>> 661bfc80e876d32da8befe53ba0234d87fc0bcc2:
>> Jan Kiszka (1):
>> pflash: Restore & fix lazy ROMD switching
>>
>> are available in the git repository at:
>>
>> git://repo.or.cz/qemu/aliguori/jvrao.git for-anthony
>
> It's pretty clear this pull request was done without doing a full 
> build before hand.
>
> I don't mean to single you out JV, but this happens too frequently 
> with pull requests so let me be clear about this.
>
> If you send me a pull request, you must do a FULL build before hand. 
> That means not specifying a '--target-list' parameter.

I ran and tested for x86. I am unaware of this.
 From now on, I will make sure not to specify ' target-list ' for the 
PULL validation build.

Regards,
JV

>
> Regards,
>
> Anthony Liguori
>
>>
>> Aneesh Kumar K.V (3):
>> virtio-9p: move 9p files around
>> virtio-9p: Print the pdu details on return
>> virtio-9p: removexattr on default acl should return 0
>>
>> Harsh Prateek Bora (2):
>> hw/virtio-9p-local.c: Remove unnecessary null char in symlink file
>> v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.
>>
>> M. Mohan Kumar (1):
>> virtio-9p: Bugfix to send correct iounit
>>
>> Stefan Hajnoczi (1):
>> vl.c: Replace -virtfs string manipulation with QemuOpts
>>
>> Makefile.objs | 10 ++++--
>> Makefile.target | 6 ++-
>> configure | 2 +
>> {hw => fsdev}/file-op-9p.h | 0
>> fsdev/qemu-fsdev.h | 2 +-
>> hw/{ => 9pfs}/virtio-9p-debug.c | 0
>> hw/{ => 9pfs}/virtio-9p-debug.h | 0
>> hw/{ => 9pfs}/virtio-9p-local.c | 2 +-
>> hw/{ => 9pfs}/virtio-9p-posix-acl.c | 17 ++++++++--
>> hw/{ => 9pfs}/virtio-9p-xattr-user.c | 2 +-
>> hw/{ => 9pfs}/virtio-9p-xattr.c | 2 +-
>> hw/{ => 9pfs}/virtio-9p-xattr.h | 0
>> hw/{ => 9pfs}/virtio-9p.c | 14 ++++++--
>> hw/{ => 9pfs}/virtio-9p.h | 4 +-
>> vl.c | 56 +++++++++++----------------------
>> 15 files changed, 62 insertions(+), 55 deletions(-)
>> rename {hw => fsdev}/file-op-9p.h (100%)
>> rename hw/{ => 9pfs}/virtio-9p-debug.c (100%)
>> rename hw/{ => 9pfs}/virtio-9p-debug.h (100%)
>> rename hw/{ => 9pfs}/virtio-9p-local.c (99%)
>> rename hw/{ => 9pfs}/virtio-9p-posix-acl.c (88%)
>> rename hw/{ => 9pfs}/virtio-9p-xattr-user.c (98%)
>> rename hw/{ => 9pfs}/virtio-9p-xattr.c (99%)
>> rename hw/{ => 9pfs}/virtio-9p-xattr.h (100%)
>> rename hw/{ => 9pfs}/virtio-9p.c (99%)
>> rename hw/{ => 9pfs}/virtio-9p.h (99%)
>>
>>
>