Patchwork (build) Patch to fix cp/cfns.gperf building issues

login
register
mail settings
Submitter Mike Stump
Date April 27, 2011, 2:35 p.m.
Message ID <71975F68-DA7A-43EF-9525-922784A470F4@comcast.net>
Download mbox | patch
Permalink /patch/93066/
State New
Headers show

Comments

Mike Stump - April 27, 2011, 2:35 p.m.
On Apr 22, 2011, at 3:54 PM, Mike Stump wrote:
> On Apr 22, 2011, at 8:12 AM, Nicola Pero wrote:
>> This patch fixes a building annoyance that I had when building on a new
>> machine (an x86_64 gnu/linux box).
>> 
>> The building failed.  It was down to two problems:
>> 
>> * due to how I got a copy of the GCC source code on the machine, the timestamp
>> of each source file was the timestamp of when it was copied to the machine (ie,
>> a random timestamp from the point of view of the building system).  This caused
>> the build system to decide that $(srcdir)/cp/cfns.h needed to be rebuilt from
>> $(srcdir)/cp/cfns.gperf (it didn't, obviously; the source code was trunk with
>> no changes).

> Ok?

Ping?
2011-04-22  Mike Stump  <mikestump@comcast.net>

	* Make-lang.in: Only run gperf in maintainer mode.
Nicola Pero - April 28, 2011, 12:02 p.m.
>> Ok?
>
> Ping?

PS: For the maintainer who will (eventually) review this patch,
the latest version, tested and with all the comments and contributions
from Joseph and Mike merged in, is --

http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01930.html

So, that's the one to review.

Patch

Index: cp/Make-lang.in
===================================================================
--- cp/Make-lang.in	(revision 172670)
+++ cp/Make-lang.in	(working copy)
@@ -105,7 +105,10 @@  cc1plus$(exeext): $(CXX_OBJS) cc1plus-ch
 	      $(CXX_OBJS) cc1plus-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS)
 
 # Special build rules.
+ifneq ($(MAINT),)
 $(srcdir)/cp/cfns.h: $(srcdir)/cp/cfns.gperf
+endif
+$(srcdir)/cp/cfns.h:
 	gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \
 		$(srcdir)/cp/cfns.gperf > $(srcdir)/cp/cfns.h