| Message ID | 20180616005323.7938-4-paul.burton@mips.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx() | expand |
Le 16/06/2018 à 02:53, Paul Burton a écrit : > With SYSCALL_DEFINEx() disabling -Wattribute-alias generically, there's > no need to duplicate that for PowerPC's pciconfig_iobase syscall. > > This reverts commit 415520373975 ("powerpc: fix build failure by > disabling attribute-alias warning in pci_32"). > > Signed-off-by: Paul Burton <paul.burton@mips.com> > Cc: Michal Marek <michal.lkml@markovi.net> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Matthew Wilcox <matthew@wil.cx> > Cc: Matthias Kaehlcke <mka@chromium.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Gideon Israel Dsouza <gidisrael@gmail.com> > Cc: Christophe Leroy <christophe.leroy@c-s.fr> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Stafford Horne <shorne@gmail.com> > Cc: Khem Raj <raj.khem@gmail.com> > Cc: He Zhe <zhe.he@windriver.com> > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mips@linux-mips.org > Cc: linuxppc-dev@lists.ozlabs.org Acked-by: Christophe Leroy <christophe.leroy@c-s.fr> > > --- > > arch/powerpc/kernel/pci_32.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c > index 4f861055a852..d63b488d34d7 100644 > --- a/arch/powerpc/kernel/pci_32.c > +++ b/arch/powerpc/kernel/pci_32.c > @@ -285,9 +285,6 @@ pci_bus_to_hose(int bus) > * Note that the returned IO or memory base is a physical address > */ > > -#pragma GCC diagnostic push > -#pragma GCC diagnostic ignored "-Wpragmas" > -#pragma GCC diagnostic ignored "-Wattribute-alias" > SYSCALL_DEFINE3(pciconfig_iobase, long, which, > unsigned long, bus, unsigned long, devfn) > { > @@ -313,4 +310,3 @@ SYSCALL_DEFINE3(pciconfig_iobase, long, which, > > return result; > } > -#pragma GCC diagnostic pop >
Paul Burton <paul.burton@mips.com> writes: > With SYSCALL_DEFINEx() disabling -Wattribute-alias generically, there's > no need to duplicate that for PowerPC's pciconfig_iobase syscall. > > This reverts commit 415520373975 ("powerpc: fix build failure by > disabling attribute-alias warning in pci_32"). > > Signed-off-by: Paul Burton <paul.burton@mips.com> > --- > > arch/powerpc/kernel/pci_32.c | 4 ---- > 1 file changed, 4 deletions(-) Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c index 4f861055a852..d63b488d34d7 100644 --- a/arch/powerpc/kernel/pci_32.c +++ b/arch/powerpc/kernel/pci_32.c @@ -285,9 +285,6 @@ pci_bus_to_hose(int bus) * Note that the returned IO or memory base is a physical address */ -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wpragmas" -#pragma GCC diagnostic ignored "-Wattribute-alias" SYSCALL_DEFINE3(pciconfig_iobase, long, which, unsigned long, bus, unsigned long, devfn) { @@ -313,4 +310,3 @@ SYSCALL_DEFINE3(pciconfig_iobase, long, which, return result; } -#pragma GCC diagnostic pop
With SYSCALL_DEFINEx() disabling -Wattribute-alias generically, there's no need to duplicate that for PowerPC's pciconfig_iobase syscall. This reverts commit 415520373975 ("powerpc: fix build failure by disabling attribute-alias warning in pci_32"). Signed-off-by: Paul Burton <paul.burton@mips.com> Cc: Michal Marek <michal.lkml@markovi.net> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Douglas Anderson <dianders@chromium.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Matthew Wilcox <matthew@wil.cx> Cc: Matthias Kaehlcke <mka@chromium.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Kees Cook <keescook@chromium.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Gideon Israel Dsouza <gidisrael@gmail.com> Cc: Christophe Leroy <christophe.leroy@c-s.fr> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Stafford Horne <shorne@gmail.com> Cc: Khem Raj <raj.khem@gmail.com> Cc: He Zhe <zhe.he@windriver.com> Cc: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/pci_32.c | 4 ---- 1 file changed, 4 deletions(-)