diff mbox series

[U-Boot,v4,3/5] efi_loader: ARM: don't attempt to enter non-secure mode twice

Message ID 20180615214715.92957-4-kettenis@openbsd.org
State Accepted
Commit f17f2001ebe1e8a78e0ef0f99e63134f91ee1354
Delegated to: Alexander Graf
Headers show
Series efi_loader: ARM: add support for ARMV7_NONSEC=y | expand

Commit Message

Mark Kettenis June 15, 2018, 9:47 p.m. UTC 
Multiple EFI binaries may be executed in sequence.  So if we already
are in non-secure mode after running the first one we should skip
the switching code since it no longer works once we're non-secure.

Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
 cmd/bootefi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Alexander Graf June 19, 2018, 9:47 a.m. UTC | #1 
> Multiple EFI binaries may be executed in sequence.  So if we already
> are in non-secure mode after running the first one we should skip
> the switching code since it no longer works once we're non-secure.
> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>

Thanks, applied to efi-next

Alex
diff mbox series

Patch

diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index 12a6b84ce6..12081cee46 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -195,6 +195,8 @@  static efi_status_t efi_run_in_el2(EFIAPI efi_status_t (*entry)(
 #endif
 
 #ifdef CONFIG_ARMV7_NONSEC
+static bool is_nonsec;
+
 static efi_status_t efi_run_in_hyp(EFIAPI efi_status_t (*entry)(
 			efi_handle_t image_handle, struct efi_system_table *st),
 			efi_handle_t image_handle, struct efi_system_table *st)
@@ -202,6 +204,8 @@  static efi_status_t efi_run_in_hyp(EFIAPI efi_status_t (*entry)(
 	/* Enable caches again */
 	dcache_enable();
 
+	is_nonsec = true;
+
 	return efi_do_enter(image_handle, st, entry);
 }
 #endif
@@ -356,7 +360,7 @@  static efi_status_t do_bootefi_exec(void *efi,
 #endif
 
 #ifdef CONFIG_ARMV7_NONSEC
-	if (armv7_boot_nonsec()) {
+	if (armv7_boot_nonsec() && !is_nonsec) {
 		dcache_disable();	/* flush cache before switch to HYP */
 
 		armv7_init_nonsec();