[U-Boot] at91sam9260ek: pull up on gpio

Submitted by Prchal Jiří on April 27, 2011, 6:38 a.m.

Details

Message ID 4DB7B9CE.1030002@aksignal.cz
State Rejected
Delegated to: Reinhard Meyer
Headers show

Commit Message

Prchal Jiří April 27, 2011, 6:38 a.m.
This fixes floating pin PB14 (DRXD) if it is unconnected, witch cause sometimes to stop autoboot by receiving char 
(noise). It turns internal pull up on this pin.
It turns pull up on all other pins where should be pull up and is set in driver too.

Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>

Comments

Reinhard Meyer June 6, 2011, 6:13 a.m.
Dear Prchal Jiří,
> This fixes floating pin PB14 (DRXD) if it is unconnected, witch cause sometimes to stop autoboot by receiving char 
> (noise). It turns internal pull up on this pin.
> It turns pull up on all other pins where should be pull up and is set in driver too.
> 
> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> 
> --- u-boot-2010.09/include/configs/at91sam9260ek.h.orig	2010-09-28 23:20:55.000000000 +0200
> +++ u-boot-2010.09/include/configs/at91sam9260ek.h	2011-04-27 08:05:16.231133740 +0200
> @@ -55,6 +55,7 @@
>    * Hardware drivers
>    */
>   #define CONFIG_AT91_GPIO	1
> +#define CONFIG_AT91_GPIO_PULLUP	1
>   #define CONFIG_ATMEL_USART	1
>   #undef CONFIG_USART0
>   #undef CONFIG_USART1
This is based on old code.

Anyway, the Pull-Ups are enabled in the current (not yet in mainline) at91sam9260ek port.

Best Regards,
Reinhard

Patch hide | download patch | download mbox

--- u-boot-2010.09/include/configs/at91sam9260ek.h.orig	2010-09-28 23:20:55.000000000 +0200
+++ u-boot-2010.09/include/configs/at91sam9260ek.h	2011-04-27 08:05:16.231133740 +0200
@@ -55,6 +55,7 @@ 
   * Hardware drivers
   */
  #define CONFIG_AT91_GPIO	1
+#define CONFIG_AT91_GPIO_PULLUP	1
  #define CONFIG_ATMEL_USART	1
  #undef CONFIG_USART0
  #undef CONFIG_USART1