Patchwork [U-Boot] mx31pdk: Clean up mx31pdk.h file

login
register
mail settings
Submitter Fabio Estevam
Date April 26, 2011, 9:04 p.m.
Message ID <1303851877-2096-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/92958/
State Accepted
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - April 26, 2011, 9:04 p.m.
No need to use '#define SYMBOL 1' to make it active.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx31pdk.h |   32 ++++++++++++++++----------------
 1 files changed, 16 insertions(+), 16 deletions(-)
Fabio Estevam - May 10, 2011, 5:50 p.m.
Hi Stefano,

Ping?

Regards,

Fabio Estevam

On 4/26/2011 6:04 PM, Fabio Estevam wrote:
> No need to use '#define SYMBOL 1' to make it active.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx31pdk.h |   32 ++++++++++++++++----------------
>  1 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> index d4c6d16..50e751a 100644
> --- a/include/configs/mx31pdk.h
> +++ b/include/configs/mx31pdk.h
> @@ -33,17 +33,17 @@
>  #include <asm/arch/imx-regs.h>
>  
>  /* High Level Configuration Options */
> -#define CONFIG_ARM1136		1	/* This is an arm1136 CPU core */
> -#define CONFIG_MX31		1	/* in a mx31 */
> +#define CONFIG_ARM1136			/* This is an arm1136 CPU core */
> +#define CONFIG_MX31			/* in a mx31 */
>  #define CONFIG_MX31_HCLK_FREQ	26000000
>  #define CONFIG_MX31_CLK32	32768
>  
>  #define CONFIG_DISPLAY_CPUINFO
>  #define CONFIG_DISPLAY_BOARDINFO
>  
> -#define CONFIG_CMDLINE_TAG		1	/* enable passing of ATAGs */
> -#define CONFIG_SETUP_MEMORY_TAGS	1
> -#define CONFIG_INITRD_TAG		1
> +#define CONFIG_CMDLINE_TAG			/* enable passing of ATAGs */
> +#define CONFIG_SETUP_MEMORY_TAGS
> +#define CONFIG_INITRD_TAG
>  
>  #if defined(CONFIG_NAND_U_BOOT) && !defined(CONFIG_NAND_SPL)
>  #define CONFIG_SKIP_LOWLEVEL_INIT
> @@ -59,11 +59,11 @@
>   * Hardware drivers
>   */
>  
> -#define CONFIG_MXC_UART		1
> -#define CONFIG_SYS_MX31_UART1	1
> +#define CONFIG_MXC_UART
> +#define CONFIG_SYS_MX31_UART1
>  
> -#define CONFIG_HARD_SPI		1
> -#define CONFIG_MXC_SPI		1
> +#define CONFIG_HARD_SPI
> +#define CONFIG_MXC_SPI
>  #define CONFIG_DEFAULT_SPI_BUS	1
>  #define CONFIG_DEFAULT_SPI_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
>  
> @@ -72,7 +72,7 @@
>  #define CONFIG_FSL_PMIC_CS	2
>  #define CONFIG_FSL_PMIC_CLK	1000000
>  #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
> -#define CONFIG_RTC_MC13783	1
> +#define CONFIG_RTC_MC13783
>  
>  /* allow to overwrite serial and ethaddr */
>  #define CONFIG_ENV_OVERWRITE
> @@ -112,9 +112,9 @@
>  		"nand write 0x81000000 0x0 0x40000\0"
>  
>  #define CONFIG_NET_MULTI
> -#define CONFIG_SMC911X		1
> +#define CONFIG_SMC911X
>  #define CONFIG_SMC911X_BASE	0xB6000000
> -#define CONFIG_SMC911X_32_BIT	1
> +#define CONFIG_SMC911X_32_BIT
>  
>  /*
>   * Miscellaneous configurable options
> @@ -139,7 +139,7 @@
>  
>  #define CONFIG_SYS_HZ			1000
>  
> -#define CONFIG_CMDLINE_EDITING	1
> +#define CONFIG_CMDLINE_EDITING
>  
>  /*-----------------------------------------------------------------------
>   * Stack sizes
> @@ -154,7 +154,7 @@
>  #define CONFIG_NR_DRAM_BANKS	1
>  #define PHYS_SDRAM_1		CSD0_BASE
>  #define PHYS_SDRAM_1_SIZE	(128 * 1024 * 1024)
> -#define CONFIG_BOARD_EARLY_INIT_F	1
> +#define CONFIG_BOARD_EARLY_INIT_F
>  
>  #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
>  #define CONFIG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
> @@ -166,9 +166,9 @@
>   * FLASH and environment organization
>   */
>  /* No NOR flash present */
> -#define CONFIG_SYS_NO_FLASH	1
> +#define CONFIG_SYS_NO_FLASH
>  
> -#define CONFIG_ENV_IS_IN_NAND		1
> +#define CONFIG_ENV_IS_IN_NAND
>  #define CONFIG_ENV_OFFSET		0x40000
>  #define CONFIG_ENV_OFFSET_REDUND	0x60000
>  #define CONFIG_ENV_SIZE			(128 * 1024)
Stefano Babic - May 10, 2011, 6:42 p.m.
On 04/26/2011 11:04 PM, Fabio Estevam wrote:
> No need to use '#define SYMBOL 1' to make it active.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx31pdk.h |   32 ++++++++++++++++----------------
>  1 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
> index d4c6d16..50e751a 100644

Applied on u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index d4c6d16..50e751a 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -33,17 +33,17 @@ 
 #include <asm/arch/imx-regs.h>
 
 /* High Level Configuration Options */
-#define CONFIG_ARM1136		1	/* This is an arm1136 CPU core */
-#define CONFIG_MX31		1	/* in a mx31 */
+#define CONFIG_ARM1136			/* This is an arm1136 CPU core */
+#define CONFIG_MX31			/* in a mx31 */
 #define CONFIG_MX31_HCLK_FREQ	26000000
 #define CONFIG_MX31_CLK32	32768
 
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
 
-#define CONFIG_CMDLINE_TAG		1	/* enable passing of ATAGs */
-#define CONFIG_SETUP_MEMORY_TAGS	1
-#define CONFIG_INITRD_TAG		1
+#define CONFIG_CMDLINE_TAG			/* enable passing of ATAGs */
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_INITRD_TAG
 
 #if defined(CONFIG_NAND_U_BOOT) && !defined(CONFIG_NAND_SPL)
 #define CONFIG_SKIP_LOWLEVEL_INIT
@@ -59,11 +59,11 @@ 
  * Hardware drivers
  */
 
-#define CONFIG_MXC_UART		1
-#define CONFIG_SYS_MX31_UART1	1
+#define CONFIG_MXC_UART
+#define CONFIG_SYS_MX31_UART1
 
-#define CONFIG_HARD_SPI		1
-#define CONFIG_MXC_SPI		1
+#define CONFIG_HARD_SPI
+#define CONFIG_MXC_SPI
 #define CONFIG_DEFAULT_SPI_BUS	1
 #define CONFIG_DEFAULT_SPI_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
 
@@ -72,7 +72,7 @@ 
 #define CONFIG_FSL_PMIC_CS	2
 #define CONFIG_FSL_PMIC_CLK	1000000
 #define CONFIG_FSL_PMIC_MODE	(SPI_MODE_0 | SPI_CS_HIGH)
-#define CONFIG_RTC_MC13783	1
+#define CONFIG_RTC_MC13783
 
 /* allow to overwrite serial and ethaddr */
 #define CONFIG_ENV_OVERWRITE
@@ -112,9 +112,9 @@ 
 		"nand write 0x81000000 0x0 0x40000\0"
 
 #define CONFIG_NET_MULTI
-#define CONFIG_SMC911X		1
+#define CONFIG_SMC911X
 #define CONFIG_SMC911X_BASE	0xB6000000
-#define CONFIG_SMC911X_32_BIT	1
+#define CONFIG_SMC911X_32_BIT
 
 /*
  * Miscellaneous configurable options
@@ -139,7 +139,7 @@ 
 
 #define CONFIG_SYS_HZ			1000
 
-#define CONFIG_CMDLINE_EDITING	1
+#define CONFIG_CMDLINE_EDITING
 
 /*-----------------------------------------------------------------------
  * Stack sizes
@@ -154,7 +154,7 @@ 
 #define CONFIG_NR_DRAM_BANKS	1
 #define PHYS_SDRAM_1		CSD0_BASE
 #define PHYS_SDRAM_1_SIZE	(128 * 1024 * 1024)
-#define CONFIG_BOARD_EARLY_INIT_F	1
+#define CONFIG_BOARD_EARLY_INIT_F
 
 #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
 #define CONFIG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
@@ -166,9 +166,9 @@ 
  * FLASH and environment organization
  */
 /* No NOR flash present */
-#define CONFIG_SYS_NO_FLASH	1
+#define CONFIG_SYS_NO_FLASH
 
-#define CONFIG_ENV_IS_IN_NAND		1
+#define CONFIG_ENV_IS_IN_NAND
 #define CONFIG_ENV_OFFSET		0x40000
 #define CONFIG_ENV_OFFSET_REDUND	0x60000
 #define CONFIG_ENV_SIZE			(128 * 1024)