Message ID | dae0a6574aaa4877121a3bab8ea50d5e768169bf.1528989474.git.baruch@tkos.co.il |
---|---|
State | Accepted |
Commit | bf3eaa3e5c8213c128a2490bc969cdb724bb149d |
Delegated to: | Stefan Roese |
Headers | show |
Series | [U-Boot,1/4] arm: mvebu: solidrun-microsom: update SPI flash compatible | expand |
running sf probe on one of my clearfogs with this set of patches applied I got SF: unrecognized JEDEC id bytes: ff, ff, ff Failed to initialize SPI flash at 1:0 (error -2) Dennis On Thu, 2018-06-14 at 18:17 +0300, Baruch Siach wrote: > Add the "spi-flash" compatible string so that the generic sf_probe > driver can probe the SPI flash on the SolidRun SOM. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > index a2627223ce3b..74f58de85c43 100644 > --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > @@ -86,7 +86,7 @@ > w25q32: spi-flash@0 { > #address-cells = <1>; > #size-cells = <1>; > - compatible = "w25q32", "jedec,spi-nor"; > + compatible = "w25q32", "jedec,spi-nor", "spi-flash"; > reg = <0>; /* Chip select 0 */ > spi-max-frequency = <3000000>; > status = "disabled";
Hi Dennis, On Thu, Jun 14, 2018 at 02:10:31PM -0500, Dennis Gilmore wrote: > running sf probe on one of my clearfogs with this set of patches > applied I got > > SF: unrecognized JEDEC id bytes: ff, ff, ff > Failed to initialize SPI flash at 1:0 (error -2) Do you use the clearfog_defconfig? Does current U-Boot master work for you? For the record, on my Clearfog Base 'sf probe' shows: SF: Detected w25q32bv with page size 256 Bytes, erase size 4 KiB, total 4 MiB This works with or without these patches. baruch > Dennis > > On Thu, 2018-06-14 at 18:17 +0300, Baruch Siach wrote: > > Add the "spi-flash" compatible string so that the generic sf_probe > > driver can probe the SPI flash on the SolidRun SOM. > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > --- > > arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > index a2627223ce3b..74f58de85c43 100644 > > --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > @@ -86,7 +86,7 @@ > > w25q32: spi-flash@0 { > > #address-cells = <1>; > > #size-cells = <1>; > > - compatible = "w25q32", "jedec,spi-nor"; > > + compatible = "w25q32", "jedec,spi-nor", "spi-flash"; > > reg = <0>; /* Chip select 0 */ > > spi-max-frequency = <3000000>; > > status = "disabled";
On Thu, 2018-06-14 at 22:23 +0300, Baruch Siach wrote: > Hi Dennis, > > On Thu, Jun 14, 2018 at 02:10:31PM -0500, Dennis Gilmore wrote: > > running sf probe on one of my clearfogs with this set of patches > > applied I got > > > > SF: unrecognized JEDEC id bytes: ff, ff, ff > > Failed to initialize SPI flash at 1:0 (error -2) > > Do you use the clearfog_defconfig? yes I did, I am testing on a clearfog pro > > Does current U-Boot master work for you? 2018.03 fails the same. I have another clearfog pro and a clearfog base I can test with, though I have the internal mmc on my base and now wish I had not done so. > > For the record, on my Clearfog Base 'sf probe' shows: > > SF: Detected w25q32bv with page size 256 Bytes, erase size 4 KiB, > total 4 MiB > > This works with or without these patches. mine does not work either way, so it is no worse off. I would like to put u-boot in SPI on them all Dennis > baruch > > > Dennis > > > > On Thu, 2018-06-14 at 18:17 +0300, Baruch Siach wrote: > > > Add the "spi-flash" compatible string so that the generic > > > sf_probe > > > driver can probe the SPI flash on the SolidRun SOM. > > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > > --- > > > arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > index a2627223ce3b..74f58de85c43 100644 > > > --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > @@ -86,7 +86,7 @@ > > > w25q32: spi-flash@0 { > > > #address-cells = <1>; > > > #size-cells = <1>; > > > - compatible = "w25q32", "jedec,spi-nor"; > > > + compatible = "w25q32", "jedec,spi-nor", "spi- > > > flash"; > > > reg = <0>; /* Chip select 0 */ > > > spi-max-frequency = <3000000>; > > > status = "disabled"; > >
Hi Dennis, On Fri, Jun 15, 2018 at 10:40:20AM -0500, Dennis Gilmore wrote: > On Thu, 2018-06-14 at 22:23 +0300, Baruch Siach wrote: > > On Thu, Jun 14, 2018 at 02:10:31PM -0500, Dennis Gilmore wrote: > > > running sf probe on one of my clearfogs with this set of patches > > > applied I got > > > > > > SF: unrecognized JEDEC id bytes: ff, ff, ff > > > Failed to initialize SPI flash at 1:0 (error -2) > > > > Do you use the clearfog_defconfig? > > yes I did, I am testing on a clearfog pro > > > Does current U-Boot master work for you? > 2018.03 fails the same. I have another clearfog pro and a clearfog base > I can test with, though I have the internal mmc on my base and now wish > I had not done so. > > > For the record, on my Clearfog Base 'sf probe' shows: > > > > SF: Detected w25q32bv with page size 256 Bytes, erase size 4 KiB, > > total 4 MiB > > > > This works with or without these patches. > mine does not work either way, so it is no worse off. I would like to > put u-boot in SPI on them all Can you read/write the SPI flash from Linux? baruch > > > On Thu, 2018-06-14 at 18:17 +0300, Baruch Siach wrote: > > > > Add the "spi-flash" compatible string so that the generic > > > > sf_probe > > > > driver can probe the SPI flash on the SolidRun SOM. > > > > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > > > --- > > > > arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > index a2627223ce3b..74f58de85c43 100644 > > > > --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > @@ -86,7 +86,7 @@ > > > > w25q32: spi-flash@0 { > > > > #address-cells = <1>; > > > > #size-cells = <1>; > > > > - compatible = "w25q32", "jedec,spi-nor"; > > > > + compatible = "w25q32", "jedec,spi-nor", "spi- > > > > flash"; > > > > reg = <0>; /* Chip select 0 */ > > > > spi-max-frequency = <3000000>; > > > > status = "disabled";
El vie, 15-06-2018 a las 19:01 +0300, Baruch Siach escribió: > Hi Dennis, > > On Fri, Jun 15, 2018 at 10:40:20AM -0500, Dennis Gilmore wrote: > > On Thu, 2018-06-14 at 22:23 +0300, Baruch Siach wrote: > > > On Thu, Jun 14, 2018 at 02:10:31PM -0500, Dennis Gilmore wrote: > > > > running sf probe on one of my clearfogs with this set of > > > > patches > > > > applied I got > > > > > > > > SF: unrecognized JEDEC id bytes: ff, ff, ff > > > > Failed to initialize SPI flash at 1:0 (error -2) > > > > > > Do you use the clearfog_defconfig? > > > > yes I did, I am testing on a clearfog pro > > > > > Does current U-Boot master work for you? > > > > 2018.03 fails the same. I have another clearfog pro and a clearfog > > base > > I can test with, though I have the internal mmc on my base and now > > wish > > I had not done so. > > > > > For the record, on my Clearfog Base 'sf probe' shows: > > > > > > SF: Detected w25q32bv with page size 256 Bytes, erase size 4 KiB, > > > total 4 MiB > > > > > > This works with or without these patches. > > > > mine does not work either way, so it is no worse off. I would like > > to > > put u-boot in SPI on them all > > Can you read/write the SPI flash from Linux? Sorry, I have been travelling, I can not access the SPI flash from Linux, I currently do not have physical access to my solid-run based boards. Nothing in my testing is any worse off. Dennis > baruch > > > > > On Thu, 2018-06-14 at 18:17 +0300, Baruch Siach wrote: > > > > > Add the "spi-flash" compatible string so that the generic > > > > > sf_probe > > > > > driver can probe the SPI flash on the SolidRun SOM. > > > > > > > > > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > > > > > --- > > > > > arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > > b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > > index a2627223ce3b..74f58de85c43 100644 > > > > > --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > > +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi > > > > > @@ -86,7 +86,7 @@ > > > > > w25q32: spi-flash@0 { > > > > > #address-cells = <1>; > > > > > #size-cells = <1>; > > > > > - compatible = "w25q32", "jedec,spi-nor"; > > > > > + compatible = "w25q32", "jedec,spi-nor", > > > > > "spi- > > > > > flash"; > > > > > reg = <0>; /* Chip select 0 */ > > > > > spi-max-frequency = <3000000>; > > > > > status = "disabled"; > >
diff --git a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi index a2627223ce3b..74f58de85c43 100644 --- a/arch/arm/dts/armada-38x-solidrun-microsom.dtsi +++ b/arch/arm/dts/armada-38x-solidrun-microsom.dtsi @@ -86,7 +86,7 @@ w25q32: spi-flash@0 { #address-cells = <1>; #size-cells = <1>; - compatible = "w25q32", "jedec,spi-nor"; + compatible = "w25q32", "jedec,spi-nor", "spi-flash"; reg = <0>; /* Chip select 0 */ spi-max-frequency = <3000000>; status = "disabled";
Add the "spi-flash" compatible string so that the generic sf_probe driver can probe the SPI flash on the SolidRun SOM. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)