diff mbox series

[Xenial,SRU,v2] UBUNTU: SAUCE: Redpine: fix soft-ap invisible issue

Message ID 1528901679-15961-1-git-send-email-siva8118@gmail.com
State New
Headers show
Series [Xenial,SRU,v2] UBUNTU: SAUCE: Redpine: fix soft-ap invisible issue | expand

Commit Message

Siva Rebbagondla June 13, 2018, 2:54 p.m. UTC 
From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400

Observed third party station is unable to scan redpine AP, when soft-ap
wizard invoked. This is because power save is not disabled for soft-ap
mode. Hence, disabling power save for soft-ap mode.

Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
---
v2: Added enhancement for soft-ap [Shrirang]
---
 ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Bader June 15, 2018, 12:30 p.m. UTC | #1 
On 13.06.2018 16:54, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> 
> Observed third party station is unable to scan redpine AP, when soft-ap
> wizard invoked. This is because power save is not disabled for soft-ap
> mode. Hence, disabling power save for soft-ap mode.
> 
> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

BugLink should be converted when committing to use the short/generic form:

BugLink: https://bugs.launchpad.net/bugs/1773400

> v2: Added enhancement for soft-ap [Shrirang]
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index bae06e3..4e0c2ae 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>  		return;
>  	}
>  	if ((!bss->assoc) &&
> -	    (adapter->ps_state == PS_ENABLED) &&
> -	    (vif->type == NL80211_IFTYPE_STATION))
> +	    (adapter->ps_state == PS_ENABLED))
>  		rsi_disable_ps(adapter);
>  	if(ieee80211_is_auth(wlh->frame_control))
>  		common->mac_ops_resumed = false;
> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>  
>  	switch (newtype) {
>  		case NL80211_IFTYPE_AP:
> +			rsi_disable_ps(adapter);
>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>  			intf_mode = AP_OPMODE;
>  			break;
>
Khalid Elmously June 18, 2018, 6:51 p.m. UTC | #2 
On 2018-06-13 20:24:39 , Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> 
> Observed third party station is unable to scan redpine AP, when soft-ap
> wizard invoked. This is because power save is not disabled for soft-ap
> mode. Hence, disabling power save for soft-ap mode.
> 
> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> ---
> v2: Added enhancement for soft-ap [Shrirang]
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index bae06e3..4e0c2ae 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>  		return;
>  	}
>  	if ((!bss->assoc) &&
> -	    (adapter->ps_state == PS_ENABLED) &&
> -	    (vif->type == NL80211_IFTYPE_STATION))
> +	    (adapter->ps_state == PS_ENABLED))
>  		rsi_disable_ps(adapter);
>  	if(ieee80211_is_auth(wlh->frame_control))
>  		common->mac_ops_resumed = false;
> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>  
>  	switch (newtype) {
>  		case NL80211_IFTYPE_AP:
> +			rsi_disable_ps(adapter);
>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>  			intf_mode = AP_OPMODE;
>  			break;

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Khalid Elmously June 19, 2018, 6:13 p.m. UTC | #3 
Applied to X


On 2018-06-13 20:24:39 , Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> 
> Observed third party station is unable to scan redpine AP, when soft-ap
> wizard invoked. This is because power save is not disabled for soft-ap
> mode. Hence, disabling power save for soft-ap mode.
> 
> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> ---
> v2: Added enhancement for soft-ap [Shrirang]
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index bae06e3..4e0c2ae 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>  		return;
>  	}
>  	if ((!bss->assoc) &&
> -	    (adapter->ps_state == PS_ENABLED) &&
> -	    (vif->type == NL80211_IFTYPE_STATION))
> +	    (adapter->ps_state == PS_ENABLED))
>  		rsi_disable_ps(adapter);
>  	if(ieee80211_is_auth(wlh->frame_control))
>  		common->mac_ops_resumed = false;
> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>  
>  	switch (newtype) {
>  		case NL80211_IFTYPE_AP:
> +			rsi_disable_ps(adapter);
>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>  			intf_mode = AP_OPMODE;
>  			break;
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Shrirang Bagul June 21, 2018, 7:35 a.m. UTC | #4 
On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> 
> Observed third party station is unable to scan redpine AP, when soft-ap
> wizard invoked. This is because power save is not disabled for soft-ap
> mode. Hence, disabling power save for soft-ap mode.
> 
> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> ---
> v2: Added enhancement for soft-ap [Shrirang]
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index bae06e3..4e0c2ae 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>  		return;
>  	}
>  	if ((!bss->assoc) &&
> -	    (adapter->ps_state == PS_ENABLED) &&
> -	    (vif->type == NL80211_IFTYPE_STATION))
> +	    (adapter->ps_state == PS_ENABLED))
>  		rsi_disable_ps(adapter);
>  	if(ieee80211_is_auth(wlh->frame_control))
>  		common->mac_ops_resumed = false;
> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>  
>  	switch (newtype) {
>  		case NL80211_IFTYPE_AP:
> +			rsi_disable_ps(adapter);
>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>  			intf_mode = AP_OPMODE;
>  			break;
Siva Rebbagondla June 21, 2018, 8:21 a.m. UTC | #5 
Hi Shrirang,

Do i need to re-submit this patch also?. I think this patch is already
applied to xenial by Khaled Elmously.

Thanks

On Thu, Jun 21, 2018 at 1:05 PM, Shrirang Bagul <
shrirang.bagul@canonical.com> wrote:

> On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:
> > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> >
> > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> >
> > Observed third party station is unable to scan redpine AP, when soft-ap
> > wizard invoked. This is because power save is not disabled for soft-ap
> > mode. Hence, disabling power save for soft-ap mode.
> >
> > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> > ---
> > v2: Added enhancement for soft-ap [Shrirang]
> > ---
> >  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c
> b/ubuntu/rsi/rsi_91x_mac80211.c
> > index bae06e3..4e0c2ae 100644
> > --- a/ubuntu/rsi/rsi_91x_mac80211.c
> > +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> > @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
> >               return;
> >       }
> >       if ((!bss->assoc) &&
> > -         (adapter->ps_state == PS_ENABLED) &&
> > -         (vif->type == NL80211_IFTYPE_STATION))
> > +         (adapter->ps_state == PS_ENABLED))
> >               rsi_disable_ps(adapter);
> >       if(ieee80211_is_auth(wlh->frame_control))
> >               common->mac_ops_resumed = false;
> > @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct
> ieee80211_hw *hw,
> >
> >       switch (newtype) {
> >               case NL80211_IFTYPE_AP:
> > +                     rsi_disable_ps(adapter);
> >                       ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
> >                       intf_mode = AP_OPMODE;
> >                       break;
<div dir="ltr"><div class="gmail_default" style="color:#073763">Hi Shrirang,</div><div class="gmail_default" style="color:#073763"><br></div><div class="gmail_default" style="color:#073763">Do i need to re-submit this patch also?. I think this patch is already applied to xenial by Khaled Elmously.</div><div class="gmail_default" style="color:#073763"><br></div><div class="gmail_default" style="color:#073763">Thanks<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 21, 2018 at 1:05 PM, Shrirang Bagul <span dir="ltr">&lt;<a href="mailto:shrirang.bagul@canonical.com" target="_blank">shrirang.bagul@canonical.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:<br>
&gt; From: Sanjay Kumar Konduri &lt;<a href="mailto:sanjay.konduri@redpinesignals.com">sanjay.konduri@<wbr>redpinesignals.com</a>&gt;<br>
&gt; <br>
&gt; BugLink: <a href="https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400" rel="noreferrer" target="_blank">https://bugs.launchpad.net/<wbr>ubuntu/+source/linux/+bug/<wbr>1773400</a><br>
&gt; <br>
&gt; Observed third party station is unable to scan redpine AP, when soft-ap<br>
&gt; wizard invoked. This is because power save is not disabled for soft-ap<br>
&gt; mode. Hence, disabling power save for soft-ap mode.<br>
&gt; <br>
&gt; Signed-off-by: Sanjay Kumar Konduri &lt;<a href="mailto:sanjay.konduri@redpinesignals.com">sanjay.konduri@<wbr>redpinesignals.com</a>&gt;<br>
&gt; Signed-off-by: Siva Rebbagondla &lt;<a href="mailto:siva.rebbagondla@redpinesignals.com">siva.rebbagondla@<wbr>redpinesignals.com</a>&gt;<br>
&gt; ---<br>
&gt; v2: Added enhancement for soft-ap [Shrirang]<br>
&gt; ---<br>
&gt;  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--<br>
&gt;  1 file changed, 2 insertions(+), 2 deletions(-)<br>
&gt; <br>
&gt; diff --git a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br>
&gt; index bae06e3..4e0c2ae 100644<br>
&gt; --- a/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br>
&gt; +++ b/ubuntu/rsi/rsi_91x_mac80211.<wbr>c<br>
&gt; @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,<br>
&gt;               return;<br>
&gt;       }<br>
&gt;       if ((!bss-&gt;assoc) &amp;&amp;<br>
&gt; -         (adapter-&gt;ps_state == PS_ENABLED) &amp;&amp;<br>
&gt; -         (vif-&gt;type == NL80211_IFTYPE_STATION))<br>
&gt; +         (adapter-&gt;ps_state == PS_ENABLED))<br>
&gt;               rsi_disable_ps(adapter);<br>
&gt;       if(ieee80211_is_auth(wlh-&gt;<wbr>frame_control))<br>
&gt;               common-&gt;mac_ops_resumed = false;<br>
&gt; @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(<wbr>struct ieee80211_hw *hw,<br>
&gt;  <br>
&gt;       switch (newtype) {<br>
&gt;               case NL80211_IFTYPE_AP:<br>
&gt; +                     rsi_disable_ps(adapter);<br>
&gt;                       ven_rsi_dbg(INFO_ZONE, &quot;Change to AP Mode\n&quot;);<br>
&gt;                       intf_mode = AP_OPMODE;<br>
&gt;                       break;</blockquote></div><br></div>
Stefan Bader June 21, 2018, 9:14 a.m. UTC | #6 
On 21.06.2018 09:35, Shrirang Bagul wrote:
> On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:
>> From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
>>
>> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>>
>> Observed third party station is unable to scan redpine AP, when soft-ap
>> wizard invoked. This is because power save is not disabled for soft-ap
>> mode. Hence, disabling power save for soft-ap mode.
>>
>> Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
>> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
>> ---
>> v2: Added enhancement for soft-ap [Shrirang]

What? Why? And you realize that NACKing should rather be done *before* we
applied it?

-Stefan
>> ---
>>  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
>> index bae06e3..4e0c2ae 100644
>> --- a/ubuntu/rsi/rsi_91x_mac80211.c
>> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
>> @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>>  		return;
>>  	}
>>  	if ((!bss->assoc) &&
>> -	    (adapter->ps_state == PS_ENABLED) &&
>> -	    (vif->type == NL80211_IFTYPE_STATION))
>> +	    (adapter->ps_state == PS_ENABLED))
>>  		rsi_disable_ps(adapter);
>>  	if(ieee80211_is_auth(wlh->frame_control))
>>  		common->mac_ops_resumed = false;
>> @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
>>  
>>  	switch (newtype) {
>>  		case NL80211_IFTYPE_AP:
>> +			rsi_disable_ps(adapter);
>>  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
>>  			intf_mode = AP_OPMODE;
>>  			break;
>>
>>
Shrirang Bagul June 21, 2018, 9:28 a.m. UTC | #7 
On Thu, 2018-06-21 at 11:14 +0200, Stefan Bader wrote:
> On 21.06.2018 09:35, Shrirang Bagul wrote:
> > On Wed, 2018-06-13 at 20:24 +0530, Siva Rebbagondla wrote:
> > > From: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> > > 
> > > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
> > > 
> > > Observed third party station is unable to scan redpine AP, when soft-ap
> > > wizard invoked. This is because power save is not disabled for soft-ap
> > > mode. Hence, disabling power save for soft-ap mode.
> > > 
> > > Signed-off-by: Sanjay Kumar Konduri <sanjay.konduri@redpinesignals.com>
> > > Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> > > ---
> > > v2: Added enhancement for soft-ap [Shrirang]
> 
> What? Why? And you realize that NACKing should rather be done *before* we
> applied it?
Sorry Stefan, I NACK'ed wrong patch. Please ignore, will be more careful in the future.

/Shrirang
> 
> -Stefan
> > > ---
> > >  ubuntu/rsi/rsi_91x_mac80211.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> > > index bae06e3..4e0c2ae 100644
> > > --- a/ubuntu/rsi/rsi_91x_mac80211.c
> > > +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> > > @@ -565,8 +565,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
> > >  		return;
> > >  	}
> > >  	if ((!bss->assoc) &&
> > > -	    (adapter->ps_state == PS_ENABLED) &&
> > > -	    (vif->type == NL80211_IFTYPE_STATION))
> > > +	    (adapter->ps_state == PS_ENABLED))
> > >  		rsi_disable_ps(adapter);
> > >  	if(ieee80211_is_auth(wlh->frame_control))
> > >  		common->mac_ops_resumed = false;
> > > @@ -860,6 +859,7 @@ static int rsi_mac80211_change_interface(struct ieee80211_hw
> > > *hw,
> > >  
> > >  	switch (newtype) {
> > >  		case NL80211_IFTYPE_AP:
> > > +			rsi_disable_ps(adapter);
> > >  			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
> > >  			intf_mode = AP_OPMODE;
> > >  			break;
> > > 
> > > 
> 
>
diff mbox series

Patch

diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
index bae06e3..4e0c2ae 100644
--- a/ubuntu/rsi/rsi_91x_mac80211.c
+++ b/ubuntu/rsi/rsi_91x_mac80211.c
@@ -565,8 +565,7 @@  static void rsi_mac80211_tx(struct ieee80211_hw *hw,
 		return;
 	}
 	if ((!bss->assoc) &&
-	    (adapter->ps_state == PS_ENABLED) &&
-	    (vif->type == NL80211_IFTYPE_STATION))
+	    (adapter->ps_state == PS_ENABLED))
 		rsi_disable_ps(adapter);
 	if(ieee80211_is_auth(wlh->frame_control))
 		common->mac_ops_resumed = false;
@@ -860,6 +859,7 @@  static int rsi_mac80211_change_interface(struct ieee80211_hw *hw,
 
 	switch (newtype) {
 		case NL80211_IFTYPE_AP:
+			rsi_disable_ps(adapter);
 			ven_rsi_dbg(INFO_ZONE, "Change to AP Mode\n");
 			intf_mode = AP_OPMODE;
 			break;