From patchwork Thu Jun 14 10:45:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 929212 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 415p1f528kz9s01 for ; Thu, 14 Jun 2018 12:47:18 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 43C07C21DB6; Thu, 14 Jun 2018 02:46:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 325C3C21D56; Thu, 14 Jun 2018 02:46:21 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 861E4C21C93; Thu, 14 Jun 2018 02:45:55 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lists.denx.de (Postfix) with ESMTPS id 78AD3C21DD3 for ; Thu, 14 Jun 2018 02:45:51 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 19:45:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,221,1526367600"; d="scan'208";a="64417133" Received: from lftan-mobl.gar.corp.intel.com (HELO ubuntu) ([10.226.248.78]) by orsmga001.jf.intel.com with SMTP; 13 Jun 2018 19:45:46 -0700 Received: by ubuntu (sSMTP sendmail emulation); Thu, 14 Jun 2018 18:45:46 +0800 From: Ley Foon Tan To: u-boot@lists.denx.de Date: Thu, 14 Jun 2018 18:45:23 +0800 Message-Id: <1528973123-21858-6-git-send-email-ley.foon.tan@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528973123-21858-1-git-send-email-ley.foon.tan@intel.com> References: <1528973123-21858-1-git-send-email-ley.foon.tan@intel.com> Cc: Marek Vasut , Tom Rini , Joe Hershberger , Chin Liang See Subject: [U-Boot] [PATCH v6 5/5] net: designware: Add reset ctrl to driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature, so only print out a warning and do not fail if a reset property is not present. If a reset property is discovered, then use it to deassert, thus bringing the IP out of reset. Signed-off-by: Ley Foon Tan Reviewed-by: Simon Glass Acked-by: Joe Hershberger --- v2: - Removed 'return' when failed to reset. v5: - Added Simon's Reviewed-by. v6: - Added Joe's Acked-by. --- drivers/net/designware.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index cf12521..6797691 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -664,6 +665,7 @@ int designware_eth_probe(struct udevice *dev) u32 iobase = pdata->iobase; ulong ioaddr; int ret; + struct reset_ctl_bulk reset_bulk; #ifdef CONFIG_CLK int i, err, clock_nb; @@ -710,6 +712,12 @@ int designware_eth_probe(struct udevice *dev) } #endif + ret = reset_get_bulk(dev, &reset_bulk); + if (ret) + dev_warn(dev, "Can't get reset: %d\n", ret); + else + reset_deassert_bulk(&reset_bulk); + #ifdef CONFIG_DM_PCI /* * If we are on PCI bus, either directly attached to a PCI root port,