[U-Boot,v6,5/5] net: designware: Add reset ctrl to driver

Message ID 1528973123-21858-6-git-send-email-ley.foon.tan@intel.com
State New
Delegated to: Tom Rini
Headers show
  • drivers: Add reset ctrl to drivers
Related show

Commit Message

Ley Foon Tan June 14, 2018, 10:45 a.m.
Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
so only print out a warning and do not fail if a reset property is not present.

If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.

Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>

- Removed 'return' when failed to reset.

- Added Simon's Reviewed-by.

- Added Joe's Acked-by.
 drivers/net/designware.c | 8 ++++++++
 1 file changed, 8 insertions(+)


diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index cf12521..6797691 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -15,6 +15,7 @@ 
 #include <miiphy.h>
 #include <malloc.h>
 #include <pci.h>
+#include <reset.h>
 #include <linux/compiler.h>
 #include <linux/err.h>
 #include <linux/kernel.h>
@@ -664,6 +665,7 @@  int designware_eth_probe(struct udevice *dev)
 	u32 iobase = pdata->iobase;
 	ulong ioaddr;
 	int ret;
+	struct reset_ctl_bulk reset_bulk;
 #ifdef CONFIG_CLK
 	int i, err, clock_nb;
@@ -710,6 +712,12 @@  int designware_eth_probe(struct udevice *dev)
+	ret = reset_get_bulk(dev, &reset_bulk);
+	if (ret)
+		dev_warn(dev, "Can't get reset: %d\n", ret);
+	else
+		reset_deassert_bulk(&reset_bulk);
 	 * If we are on PCI bus, either directly attached to a PCI root port,