From patchwork Wed Jun 13 17:44:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Nefedov X-Patchwork-Id: 928998 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="L0O+aTzo"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415Z0l0B7vz9s4Y for ; Thu, 14 Jun 2018 03:45:41 +1000 (AEST) Received: from localhost ([::1]:35953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT9px-0003M8-JC for incoming@patchwork.ozlabs.org; Wed, 13 Jun 2018 13:45:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT9pF-0003LC-HW for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:44:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT9pC-000718-RT for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:44:53 -0400 Received: from mail-eopbgr10138.outbound.protection.outlook.com ([40.107.1.138]:47432 helo=EUR02-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fT9pC-0006sA-Ib; Wed, 13 Jun 2018 13:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2I8ydvYJbbLHSt1UfORyPn9JJ2p8anq19/Jgo3cmlQ=; b=L0O+aTzoqGZRArMCAVsY4OST10nx76mY1ztA9CPQzyLJ3r5FiSyn0A0h+a7lr+IHJhiik8/rh5WOVJmDOkfqcV1v816GQSeCkAHHrQdqeQ9poB+E1/2QTvXpPFfwroPFUzlIHSsGpF5dmCBLBUf5kD5uzXeTPw6gh2CMYercjg4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=anton.nefedov@virtuozzo.com; Received: from xantnef-ws.sw.ru (195.214.232.6) by AM0PR08MB3347.eurprd08.prod.outlook.com (2603:10a6:208:5f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Wed, 13 Jun 2018 17:44:46 +0000 From: Anton Nefedov To: qemu-devel@nongnu.org Date: Wed, 13 Jun 2018 20:44:19 +0300 Message-Id: <1528911866-37489-2-git-send-email-anton.nefedov@virtuozzo.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528911866-37489-1-git-send-email-anton.nefedov@virtuozzo.com> References: <1528911866-37489-1-git-send-email-anton.nefedov@virtuozzo.com> MIME-Version: 1.0 X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0902CA0023.eurprd09.prod.outlook.com (2603:10a6:3:e5::33) To AM0PR08MB3347.eurprd08.prod.outlook.com (2603:10a6:208:5f::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1c56412-cc3b-48fb-d32e-08d5d1555ad9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR08MB3347; X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 3:pI7HxOnTj+1JZxr4AX85jNybgeaAlxtLzMJe6YfqvZ2JAQDTsxzg4JGBRMc+28hSPqpOWW3iz4t6ETbYKmanJ5KeJ8I3RyEsvmJud0BBe6jfSZno0J5M1exn6qm6ne8rs5L6jFHMw3PRV6EJeGHEZaV8vk3SzNCZmqm+QZTs400yJY+75cTijC/dy8fTECvG5utNV7mvq3QhyagFl/Z8Vf3GOANb2M0CGNjKW0muhWdAIrwDgiJPfXe2bQERFZl4; 25:ZOeOkRcgm1UHmd/wrOiuLyO3jQdSvppYup6GboWRZUassXh3Ro5i8tMoRb8r2vjeRTdGZrAuD5rny2XT8kxtoUZ3HqIz6En1E43Thk0dRCH8JU4U9neYBJcwGDjoXv9ingNVyzi+i7QGd7i83mh6gZAJnJ1QF7DG5hqnaXdAx7eRe68xa04MsnYaMh92pfgV6UWniOw60qxxlNxFQvE0dspIk7WB/fg7SC27AdaKu8FQ4vssQeHcPuAkkPdO4IKlAE2j4wBrc0mDjTjtLcZpez+CWVPKZOvbS85yZ2vkRjju7v3SE0+NUVbSYnPHKhJ3QLh6DHbtgWY8mw3RQ04UMg==; 31:j5J3LEMHA+0DNrOjuBZQxNleGWV+Ml4nQDLOK+fUU5sFhBTbn4g6Snryqaz3dEXNopav1576yABV3NpNQEhNA9Lv31ZToAUotNfhG1BoOHItS2K+fz4/LI6P3h9sGCgUOHfP/N5NB5DdJHfkx2zF/LgemhmQ+rTlML1vSmB7stnTOFI8Y88Sh+Sv1LGhNJEsEe/8D5IcdE3Jj60uODiMsRsBVCmySfv7VpsCsKfx9ug= X-MS-TrafficTypeDiagnostic: AM0PR08MB3347: X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 20:nc3SUtsVJg3KLrM8yDc6j8ojc4Tp/ZCvn7K0UCvcOIxzIpZEjXuBtOUv65eoXCp8nmX1Ost/j/1tzLKdhmH7BxMiE61iE35hHrd1yWLggxv5Tnx1H2P9cZFC/efpDFUKyYILnufC814vWjtfO3WWuuzyDwk7qwDf6qan06xmVlbEQaRh/v6QRlMpfnJIS4pM9yYyzHc6e0jPD1IheiLIvJ7h0hUTCSZKA8HLxn2ZBuB5+2yarL7ng6YOAhqgYUbHKASsNXhoKwjD0MN12n4RCCQNX1Gw+XqAWd3fXh4sUFTqLYUfVsmQEAxeFSaNZWxETREIppMPhIqQN7pTOsnNMQBBRxxWkeTObza2d99ujisLq7JGGGRJiKxaUnbzPdy/8nPu9o47upaallY+tBRAnupJQP7NIo3Vn61pRQaYsICYn9e8J2iXc88oROUoCtgP2PmBvb2o/NfsaPArwoVQfEg4y37JCMRRLEHvSXvxu3J+fHZGkeu7LeSAsnNqf1CI; 4:uHnasL/ePZlTt34Afhlx9eFPCesWQjiNQser0htOqunoRLj6+xVcgQdZJv8Occ7eoXigCCvBhMcbo0V0ZLi/ydQ8+ASGPwgeab7PGI3qIunRc+vSman9qwu7CavO4WKjnZRDEkPW+0tYEQEbEdnqMi3E08D15+DIMgY+sn4IXquAaDbgVNwGjqvbvadv/xE1pK/CxdoA6LNa1HOv/fIKe3qUMKQvFgiIgz4Zm6x0fE8742ngueHufnQsFWbmnve7CMueNJbCjPtwm4sYG2JWiw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:AM0PR08MB3347; BCL:0; PCL:0; RULEID:; SRVR:AM0PR08MB3347; X-Forefront-PRVS: 07025866F6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(39850400004)(366004)(39380400002)(199004)(189003)(50466002)(2351001)(386003)(4326008)(2361001)(59450400001)(6512007)(52116002)(105586002)(486006)(478600001)(106356001)(44832011)(53416004)(107886003)(51416003)(53936002)(76176011)(11346002)(956004)(446003)(2616005)(476003)(69596002)(6486002)(48376002)(16526019)(6506007)(7736002)(97736004)(186003)(5660300001)(6666003)(25786009)(6916009)(305945005)(8936002)(6116002)(3846002)(50226002)(66066001)(36756003)(8676002)(86362001)(47776003)(55236004)(68736007)(316002)(2906002)(16586007)(81166006)(26005)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR08MB3347; H:xantnef-ws.sw.ru; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR08MB3347; 23:kv0ITNhhg0b60hI0KdLW5T+uxWpfSIZFTBYlXdRHR?= WuKR4G2BaubjAa8noYTMEt9fQMMPhfyzz//76renZ7/gaf3XaSLqKfASsH7XjwNTyzY410NRjeKTSbvmckccMpqJ4XGEkYDyjGkuh9sH5E4rNDU+hmv14roeEgul7UjeufL9+CW6U3DtWRCN8dBPArAU3yUaRYvYzRbYuEu57Adw9dEoOdupi+5RWbhFMVLZLjObFqW5WXUhf/nXJutJS48uY+1wHUWd6WWI+qGPx/4ysWSfR7yoLE5EFagK+FjJgNPyY3MVqJiVd6EOhZ8njs1iC/81K1GMN5WQg9u4gSmuX8kh6uYKNV5gejzBln9iw0Q3a99c5MWl60dUSoB2dfdDzWfTN5OQ3WexmVQ+Fxlu8j3rcmtCLOEDJ+1DQu82+PQgX9fOHI3ZC3KrLBP7a2Qakzf9EMu8GlUEvmlKHFPAVAPH5DuZuMCTVWHvINygC+SH+JfXAB6qB4ziFN6Yc1/dZyFFueGaLj+dHLeworL8JBHG5+6nES90PIqpRfMv+NriB7IRgPS2pYUbQjqZPO7Z/IEQ4UQ9XdrHXyVZnm0sAj82JeyshESOzM/Ib2Q3bhuZ1X/jRpSYarHlVBeKxzxypSX4kqTG4o6QVpanbqDc0uWV4VUBwBgoxf9pn0IV/fbVtcyD4hnBHze+q01gLCKcarPV0oITjpeBVBxoHiVexr/ODPy7x3eRPVZF43eijXhBIC4DV0SWGHX9A8GKUq7f2LazS/oyRzd0FlM3D07X/A/28QosyN+/ChoJhSTRi+G9J0XprCX/OvYiNUC1VFGyRh5JYfedKCkfMBvO/pJLdlNpBEUHAuNINoFgirMP2m2OqV/L9Hp1oY5B0sUAvjMFyFI4Pq5MUfNzN4VehjjCcewQjs1FSZE+xCdr8PqlKMAOwGmWebdzWM1P5p4mICbar4ygdeRuKIrYZKtVxYcj7BSkjnoh61Oeuo7u22ibTVERKKaDKsAE2TBttjpP+ol408Bg2INLWNuoVyFY7FYs1WSnjaBiju1GwPaGskXm2TwXz+eJUbxtE3Fr/z9aPHUmmVyAHZCynVrpRF1vLF3wR/5O5JA9bOvc4hJ0nXGMOsZRLHnD3kSeiOctQbmGh/kG7ulyUYwvD1TKUAh0/v3cm3g2/AJzKTLO63RHbl0wQWZcH3kyxZnd+j8ON620avY0+8P09dFo36/Qb/G3e/WumZ53s62Q5Yqg05GCTiXyuNFfHJYgozlgDO2Ku6ZsEWf7hnLlTJGnAWUxJ3/B46NViMzkOq7mVkxjcCcEzjtpXCFR+NLfYpQiurcMZyAs4ES3GANAdH0/tvl2j4ySv8pGA== X-Microsoft-Antispam-Message-Info: 9yBUnJuWHS7mbE0TsPEbIl6+xlREQCiQ+3ZGtgyVOeNMyOFDa/yGdx8ptpj/eA0CjpTXgsG3kV6xFxGuQrb6jRO+qKixPsXupoRVNBbv993PxYBvJN7VatrgrR5/nK4jEcInRffa1NQ5daWrTrI3pZbTP1E86ElqXFAQjIOvI9s0r8UThEqW18+LnuBzJRgv X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 6:xoJpjWIVj7nc8qB7/evsXJyKpxEwvNgdNyViYUbICPaPjYWVf51FW62tmPFnAErDWBmHjrnbEB3TDfqyPu7py9Ey3JEgHjkgWyDanAfWzFIj4dMvixOXP9g6gBzABnU2G4BLcooTfj6NwQBrOuUR2nWFIRgqgBz6tmUtz8KapxKvV1TeIQ9FYzZiPy+heQa4i0G/PYd+srvIPZYwRjBhI9oywHH+HpQGdvBgxzlc8h6tPV8ZDVOd13oTwE6zH+arTZbOy8TJz6gkOpAGspsL9yRV9XOFWXx3UyazD0Hr82qyfrCBGB5hzjbpD5DTp3w1nGNF3ftIjPT+PhcQaIiflTfVJ44m1+c3oTjkGl3BF0Kd9GbXE5h52aAO4mgxLNKaJeD5NA8tH7GicdnwluQGjWKKWkkZQmUQ06Hl3LNsTrzvCnWgMrx4M1wwXus3bYnLvgCWAazs1Z2YaoecDDhfyg==; 5:hDVPx6dgARw/bZwiG1pKdGzHmPVT65U07wPN568c+t2bkCWMtHvCyFKB/66Gjax2wvSbgzZWti1rU+tPV+/yBBOKGSTR2BHG8eEbooGKrqGpRyAysGqLx2ev9oMAkuIIacF4cZVKmngu9xLTyk+ucPQNXq2Ow4xWJls7sV2s4Mc=; 24:bB+f6+M1QyAiD+RsYq0Agw17svHRTgH1WNegT1IOHnGYZTXdhfLreBCHONnyyjkPKeFqgEe1HQDC27JRQugyI2pjHRz21wEYBv5HUzfw2DM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR08MB3347; 7:5NTAXUkPNo3JdXEmomXP35H8R+sPfiyCI2oeTfrnDNaRxGq+JLV3FgOP3wz/xcatre6FHLE05iV3Hcd0bIXOb3B13MfYC+z3g5KJFe0pe7pBNXhRzuEYUgt2ED6iUXWY2zz2afPd87KgHpwToXN7LuSYHs2KlkkDkPKrW0NJ7CHHT6jaq+P/uibwQCoUkGfnGRahwdqTxI0QDSN5I2SanOgNzFyJF8HpFiRhBHKLNTq48yrWpuU7wdaqbkfvEZ32; 20:vm9l6DIX5a6UnxR1appSgxeBQDzoNOFmH9fusWubwnawtQz7/lNer0lMctHTAFGkOE7rY1NGOO4idaOcm5dilJJ4SAlRMR6nRL3EZ5IG/UBBsh3HVrF5qun9JZoRah4YuJvVnCCk1V7RCjW+y/b+D8lujt4rAoJPlivv4N59j5U= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2018 17:44:46.1097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1c56412-cc3b-48fb-d32e-08d5d1555ad9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3347 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.1.138 Subject: [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Anton Nefedov , berto@igalia.com, den@virtuozzo.com, qemu-block@nongnu.org, armbru@redhat.com, mreitz@redhat.com, pbonzini@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Make the stat fields definition slightly more readable. Also reorder total_time_ns stats read-write-flush as done elsewhere. Cosmetic change only. Signed-off-by: Anton Nefedov --- qapi/block-core.json | 34 +++++++++++++++++++++++----------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index b3e94d8..ee75aef 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -784,12 +784,12 @@ # @flush_operations: The number of cache flush operations performed by the # device (since 0.15.0) # -# @flush_total_time_ns: Total time spend on cache flushes in nano-seconds -# (since 0.15.0). +# @rd_total_time_ns: Total time spent on reads in nanoseconds (since 0.15.0). # -# @wr_total_time_ns: Total time spend on writes in nano-seconds (since 0.15.0). +# @wr_total_time_ns: Total time spent on writes in nanoseconds (since 0.15.0). # -# @rd_total_time_ns: Total_time_spend on reads in nano-seconds (since 0.15.0). +# @flush_total_time_ns: Total time spent on cache flushes in nanoseconds +# (since 0.15.0). # # @wr_highest_offset: The offset after the greatest byte written to the # device. The intended use of this information is for @@ -842,14 +842,26 @@ # Since: 0.14.0 ## { 'struct': 'BlockDeviceStats', - 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', 'rd_operations': 'int', - 'wr_operations': 'int', 'flush_operations': 'int', - 'flush_total_time_ns': 'int', 'wr_total_time_ns': 'int', - 'rd_total_time_ns': 'int', 'wr_highest_offset': 'int', - 'rd_merged': 'int', 'wr_merged': 'int', '*idle_time_ns': 'int', + 'data': {'rd_bytes': 'int', 'wr_bytes': 'int', + + 'rd_operations': 'int', 'wr_operations': 'int', + 'flush_operations': 'int', + + 'rd_total_time_ns': 'int', 'wr_total_time_ns': 'int', + 'flush_total_time_ns': 'int', + + 'wr_highest_offset': 'int', + + 'rd_merged': 'int', 'wr_merged': 'int', + + '*idle_time_ns': 'int', + 'failed_rd_operations': 'int', 'failed_wr_operations': 'int', - 'failed_flush_operations': 'int', 'invalid_rd_operations': 'int', - 'invalid_wr_operations': 'int', 'invalid_flush_operations': 'int', + 'failed_flush_operations': 'int', + + 'invalid_rd_operations': 'int', 'invalid_wr_operations': 'int', + 'invalid_flush_operations': 'int', + 'account_invalid': 'bool', 'account_failed': 'bool', 'timed_stats': ['BlockDeviceTimedStats'], '*x_rd_latency_histogram': 'BlockLatencyHistogramInfo',