[v3,01/12] macintosh/via-pmu: Fix section mismatch warning

Message ID 68c2acba4f518626b02bb8f37c55d052643a99df.1528885172.git.fthain@telegraphics.com.au
State Superseded
Headers show
  • macintosh: Resolve various PMU driver problems
Related show

Commit Message

Finn Thain June 13, 2018, 10:38 a.m.
The pmu_init() function has the __init qualifier, but the ops struct
that holds a pointer to it does not. This causes a build warning.
The driver works fine because the pointer is only dereferenced early.

The function is so small that there's negligible benefit from using
the __init qualifier. Remove it to fix the warning, consistent with
the other ADB drivers.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
 drivers/macintosh/via-pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 433dbeddfcf9..fd3c5640d586 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -378,7 +378,7 @@  static int pmu_probe(void)
 	return vias == NULL? -ENODEV: 0;
-static int __init pmu_init(void)
+static int pmu_init(void)
 	if (vias == NULL)
 		return -ENODEV;