Patchwork [3/4] UBIFS: print useful debugging messages when cannot recover gc_lnum

login
register
mail settings
Submitter Artem Bityutskiy
Date April 26, 2011, 7:29 a.m.
Message ID <1303802963-31612-3-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/92865/
State Accepted
Commit 6d5904e062d5cb28b705d49a35682e0871b3f382
Headers show

Comments

Artem Bityutskiy - April 26, 2011, 7:29 a.m.
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

If we fail to recover the gc_lnum we just return an error and it then
it is difficult to figure out why this happened. This patch adds useful
debugging information which should make it easier to debug the failure.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 fs/ubifs/recovery.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Patch

diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 3e0eedbe..3d2598d 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -1177,6 +1177,8 @@  find_free:
 	lnum = ubifs_find_free_leb_for_idx(c);
 	if (lnum < 0) {
 		dbg_err("could not find an empty LEB");
+		dbg_dump_lprops(c);
+		dbg_dump_budg(c, &c->bi);
 		return lnum;
 	}
 	/* And reset the index flag */