[U-Boot,v4,4/4] riscv: Remove unused _relocate arguments

Message ID 11a676b108f09c2c0755a2237cc3234d636559c3.1528825347.git.ivan.gorinov@intel.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series
  • x86: use EFI calling convention for efi_main on x86_64
Related show

Commit Message

Ivan Gorinov June 12, 2018, 5:52 p.m.
EFI image handle and system table are not used in _relocate().

Signed-off-by: Ivan Gorinov <ivan.gorinov@intel.com>
---
 arch/riscv/lib/reloc_riscv_efi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bin Meng June 13, 2018, 1:38 a.m. | #1
Hi Ivan,

On Wed, Jun 13, 2018 at 1:52 AM, Ivan Gorinov <ivan.gorinov@intel.com> wrote:
> EFI image handle and system table are not used in _relocate().
>
> Signed-off-by: Ivan Gorinov <ivan.gorinov@intel.com>
> ---
>  arch/riscv/lib/reloc_riscv_efi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/riscv/lib/reloc_riscv_efi.c b/arch/riscv/lib/reloc_riscv_efi.c
> index 8b4b2b1..51b7520 100644
> --- a/arch/riscv/lib/reloc_riscv_efi.c
> +++ b/arch/riscv/lib/reloc_riscv_efi.c
> @@ -50,8 +50,7 @@
>  #define ELF_R_TYPE     ELF32_R_TYPE
>  #endif
>
> -efi_status_t _relocate(long ldbase, Elf_Dyn *dyn, efi_handle_t image,
> -                      struct efi_system_table *systab)
> +efi_status_t _relocate(long ldbase, Elf_Dyn *dyn, efi_handle_t image)

This still has the image argument.

>  {
>         long relsz = 0, relent = 0;
>         Elf_Rela *rel = 0;
> --

Regards,
Bin

Patch

diff --git a/arch/riscv/lib/reloc_riscv_efi.c b/arch/riscv/lib/reloc_riscv_efi.c
index 8b4b2b1..51b7520 100644
--- a/arch/riscv/lib/reloc_riscv_efi.c
+++ b/arch/riscv/lib/reloc_riscv_efi.c
@@ -50,8 +50,7 @@ 
 #define ELF_R_TYPE	ELF32_R_TYPE
 #endif
 
-efi_status_t _relocate(long ldbase, Elf_Dyn *dyn, efi_handle_t image,
-		       struct efi_system_table *systab)
+efi_status_t _relocate(long ldbase, Elf_Dyn *dyn, efi_handle_t image)
 {
 	long relsz = 0, relent = 0;
 	Elf_Rela *rel = 0;