[ovs-dev] rhel: Add python-netifaces as a dependency for openvswitch-test

Message ID 816f99c4c640635cc8d8b26a8b27b7b0e68a6f6e.1528795660.git.tredaelli@redhat.com
State Accepted
Headers show
Series
  • [ovs-dev] rhel: Add python-netifaces as a dependency for openvswitch-test
Related show

Commit Message

Timothy Redaelli June 12, 2018, 9:27 a.m.
Currently python-netifaces is needed for ovs-tcpdump that is installed
by openvswitch-test package.

This commit adds {python,python2}-netifaces as a dependency for the
openvswitch-test package.

Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 rhel/openvswitch-fedora.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole June 12, 2018, 7:37 p.m. | #1
Timothy Redaelli <tredaelli@redhat.com> writes:

> Currently python-netifaces is needed for ovs-tcpdump that is installed
> by openvswitch-test package.
>
> This commit adds {python,python2}-netifaces as a dependency for the
> openvswitch-test package.
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

This should remove a step from the installation procedure.  Thanks,
Timothy!
Ben Pfaff June 14, 2018, 8:52 p.m. | #2
On Tue, Jun 12, 2018 at 03:37:09PM -0400, Aaron Conole wrote:
> Timothy Redaelli <tredaelli@redhat.com> writes:
> 
> > Currently python-netifaces is needed for ovs-tcpdump that is installed
> > by openvswitch-test package.
> >
> > This commit adds {python,python2}-netifaces as a dependency for the
> > openvswitch-test package.
> >
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> 
> Acked-by: Aaron Conole <aconole@redhat.com>
> 
> This should remove a step from the installation procedure.  Thanks,
> Timothy!

Thanks Timothy (and Aaron).  I applied this to master.  If you want it
backported, please let me know.

Patch

diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 9be16ffe7..d88ed8ec4 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -145,7 +145,7 @@  Summary: Open vSwitch testing utilities
 License: ASL 2.0
 BuildArch: noarch
 Requires: %{_py2}-openvswitch = %{version}-%{release}
-Requires: %{_py2} %{_py2}-twisted
+Requires: %{_py2} %{_py2}-netifaces %{_py2}-twisted
 
 %description test
 Utilities that are useful to diagnose performance and connectivity