| Message ID | 20180612082823.25507-1-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | travis: display config.log when configure fails | expand |
On Tue, 06/12 09:28, Daniel P. Berrangé wrote: > When configure fails in CI systems we must be able to see the contents > of the config.log file to diagnose the root cause. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 814be151f4..fc9a1fe8a8 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -69,7 +69,7 @@ before_install: > - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ > - git submodule update --init --recursive > before_script: > - - ./configure ${CONFIG} > + - ./configure ${CONFIG} || (cat config.log && exit 1) > script: > - make ${MAKEFLAGS} && ${TEST_CMD} > matrix: > @@ -151,4 +151,4 @@ matrix: > - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user" > - TEST_CMD="" > before_script: > - - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log > + - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || (cat config.log && exit 1) > -- > 2.17.0 > Makes sense. this fixes the status code of before_script, though previously as we mask the error with the "|| cat config.log", make will still fail. Reviewed-by: Fam Zheng <famz@redhat.com>
On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote: > When configure fails in CI systems we must be able to see the contents > of the config.log file to diagnose the root cause. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 814be151f4..fc9a1fe8a8 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -69,7 +69,7 @@ before_install: > - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ > - git submodule update --init --recursive > before_script: > - - ./configure ${CONFIG} > + - ./configure ${CONFIG} || (cat config.log && exit 1) If you want one less fork, you can spell this as: - ./configure ${CONFIG} || { cat config.log && exit 1; } Either way, the patch makes sense, so: Reviewed-by: Eric Blake <eblake@redhat.com>
On 06/12/2018 09:15 AM, Eric Blake wrote: > On 06/12/2018 03:28 AM, Daniel P. Berrangé wrote: >> When configure fails in CI systems we must be able to see the contents >> of the config.log file to diagnose the root cause. >> >> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> >> --- >> .travis.yml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.travis.yml b/.travis.yml >> index 814be151f4..fc9a1fe8a8 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -69,7 +69,7 @@ before_install: >> - wget -O - >> http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | >> tar -xvJ >> - git submodule update --init --recursive >> before_script: >> - - ./configure ${CONFIG} >> + - ./configure ${CONFIG} || (cat config.log && exit 1) > > If you want one less fork, you can spell this as: > > - ./configure ${CONFIG} || { cat config.log && exit 1; } I was just digging for your previous mail explaining that to use as reference ;) > > Either way, the patch makes sense, so: > Reviewed-by: Eric Blake <eblake@redhat.com> > preferably using {: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Daniel P. Berrangé <berrange@redhat.com> writes: > When configure fails in CI systems we must be able to see the contents > of the config.log file to diagnose the root cause. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> queued thanks. <snip> -- Alex Bennée
diff --git a/.travis.yml b/.travis.yml index 814be151f4..fc9a1fe8a8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -69,7 +69,7 @@ before_install: - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ - git submodule update --init --recursive before_script: - - ./configure ${CONFIG} + - ./configure ${CONFIG} || (cat config.log && exit 1) script: - make ${MAKEFLAGS} && ${TEST_CMD} matrix: @@ -151,4 +151,4 @@ matrix: - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user" - TEST_CMD="" before_script: - - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log + - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || (cat config.log && exit 1)
When configure fails in CI systems we must be able to see the contents of the config.log file to diagnose the root cause. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)