[ovs-dev,v1] tests: Enable Valgrind for userspace system tests.

Message ID 1528764702-62964-1-git-send-email-dlu998@gmail.com
State Accepted
Headers show
Series
  • [ovs-dev,v1] tests: Enable Valgrind for userspace system tests.
Related show

Commit Message

Darrell Ball June 12, 2018, 12:51 a.m.
Signed-off-by: Darrell Ball <dlu998@gmail.com>
---
 tests/automake.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Ben Pfaff June 14, 2018, 8:55 p.m. | #1
On Mon, Jun 11, 2018 at 05:51:42PM -0700, Darrell Ball wrote:
> Signed-off-by: Darrell Ball <dlu998@gmail.com>

Thanks, applied to master.

Patch

diff --git a/tests/automake.mk b/tests/automake.mk
index c420b29..8224e5a 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -233,6 +233,13 @@  check-kernel-valgrind: all $(valgrind_wrappers) $(check_DATA)
 	@echo '----------------------------------------------------------------------'
 	@echo 'Valgrind output can be found in tests/system-kmod-testsuite.dir/*/valgrind.*'
 	@echo '----------------------------------------------------------------------'
+check-userspace-valgrind: all $(valgrind_wrappers) $(check_DATA)
+	set $(SHELL) '$(SYSTEM_USERSPACE_TESTSUITE)' -C tests VALGRIND='$(VALGRIND)' AUTOTEST_PATH='tests/valgrind:$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS) -j1; \
+	"$$@" || (test X'$(RECHECK)' = Xyes && "$$@" --recheck)
+	@echo
+	@echo '----------------------------------------------------------------------'
+	@echo 'Valgrind output can be found in tests/system-userspace-testsuite.dir/*/valgrind.*'
+	@echo '----------------------------------------------------------------------'
 check-helgrind: all $(valgrind_wrappers) $(check_DATA)
 	-$(SHELL) '$(TESTSUITE)' -C tests CHECK_VALGRIND=true VALGRIND='$(HELGRIND)' AUTOTEST_PATH='tests/valgrind:$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS)